Salem Ba-rabuod

[Barboud]

No description provided.

[github-actions]

📝 HackYourFuture auto grade

Assignment Score: 0 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 0
🧪 The auto grade is experimental and still being improved

Test Details

[mvcatsifma]

@Barboud Taking this review.

[mvcatsifma]

@Barboud

The output matches exactly — well done. The implementation is correct and the storage abstraction works as intended.

A few points to improve:

Commit messages
"solved the assignment" as a single commit covers everything: schema, migration, and all functions. This makes it hard to understand what changed and why. Prefer smaller, incremental commits (e.g. one function or logical step at a time) with descriptive messages.

Tests
There are no tests. In this case manual verification was done correctly, but it’s still fragile. A few simple assertions would make the implementation more robust and prevent regressions.

Assignment scope
app.js was modified (quote style changes). The README explicitly says not to modify this file, so it should be left unchanged.

cc @stasel

[Barboud]

@Barboud

The output matches exactly — well done. The implementation is correct and the storage abstraction works as intended.

A few points to improve:

Commit messages "solved the assignment" as a single commit covers everything: schema, migration, and all functions. This makes it hard to understand what changed and why. Prefer smaller, incremental commits (e.g. one function or logical step at a time) with descriptive messages.

Tests There are no tests. In this case manual verification was done correctly, but it’s still fragile. A few simple assertions would make the implementation more robust and prevent regressions.

Assignment scope app.js was modified (quote style changes). The README explicitly says not to modify this file, so it should be left unchanged.

cc @stasel

Thanks @mvcatsifma for the feedback.

I have already applied your advice about commit messages in my latest assignment.
Regarding tests, I'm still a bit confused. Should I write a test unit for every single function, or just the main parts?
I'll also be more careful with the assignment requirements next time. Thanks again!