-
Notifications
You must be signed in to change notification settings - Fork 18
Yana P. #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
YanaP1312
wants to merge
4
commits into
HackYourAssignment:main
Choose a base branch
from
YanaP1312:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Yana P. #10
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,107 @@ | ||
| // API documentation: https://www.thecocktaildb.com/api.php | ||
|
|
||
| import path from 'path'; | ||
| import path from "path"; | ||
| import fsPromises from "node:fs/promises"; | ||
|
|
||
| const BASE_URL = 'https://www.thecocktaildb.com/api/json/v1/1'; | ||
| const BASE_URL = "https://www.thecocktaildb.com/api/json/v1/1"; | ||
|
|
||
| // Add helper functions as needed here | ||
|
|
||
| function formatHeading(drink) { | ||
| return `## ${drink.strDrink}`; | ||
| } | ||
|
|
||
| function formatThumbnail(drink) { | ||
| return ``; | ||
| } | ||
|
|
||
| function formatCategory(drink) { | ||
| return `**Category**: ${drink.strCategory}`; | ||
| } | ||
|
|
||
| function formatAlcoholic(drink) { | ||
| return drink.strAlcoholic === "Alcoholic" | ||
| ? "**Alcoholic**: Yes" | ||
| : "**Alcoholic**: No"; | ||
| } | ||
|
|
||
| function formatInstructions(drink) { | ||
| return `### Instructions\n\n${drink.strInstructions}`; | ||
| } | ||
|
|
||
| function formatServeIn(drink) { | ||
| return `Serve in: ${drink.strGlass}`; | ||
| } | ||
|
|
||
| function cocktailIngredients(drink) { | ||
| if (!drink) return; | ||
|
|
||
| let ingredients = []; | ||
|
|
||
| for (let i = 1; i <= 15; i++) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice loop |
||
| const ingredient = drink[`strIngredient${i}`]; | ||
| const measure = drink[`strMeasure${i}`]; | ||
|
|
||
| if (!ingredient) break; | ||
|
|
||
| ingredients.push(`${measure || ""}${ingredient}`.trim()); | ||
| } | ||
|
|
||
| return ingredients; | ||
| } | ||
|
|
||
| function generateMarkdownContent(data) { | ||
| return data.drinks | ||
| .map((drink) => { | ||
| const ingredients = cocktailIngredients(drink) | ||
| .map((ingredient) => `- ${ingredient}`) | ||
| .join("\n"); | ||
|
|
||
| return [ | ||
| formatHeading(drink), | ||
| "", | ||
| formatThumbnail(drink), | ||
| "", | ||
| formatCategory(drink), | ||
| "", | ||
| formatAlcoholic(drink), | ||
| "", | ||
| "### Ingredients", | ||
| "", | ||
| ingredients, | ||
| "", | ||
| formatInstructions(drink), | ||
| "", | ||
| formatServeIn(drink), | ||
| "", | ||
| ].join("\n"); | ||
| }) | ||
| .join("\n"); | ||
| } | ||
|
|
||
| async function fetchCocktailData(url) { | ||
| const response = await fetch(url); | ||
|
|
||
| if (!response.ok) { | ||
| throw new Error(`Request failed with status ${response.status}`); | ||
| } | ||
|
|
||
| return await response.json(); | ||
| } | ||
|
|
||
| function validateCocktailData(data) { | ||
| if (!data.drinks) { | ||
| throw new Error("No cocktails found with that name."); | ||
| } | ||
| } | ||
|
|
||
| async function saveMarkdown(path, content) { | ||
| await fsPromises.writeFile(path, content); | ||
| } | ||
|
|
||
| export async function main() { | ||
| if (process.argv.length < 3) { | ||
| console.error('Please provide a cocktail name as a command line argument.'); | ||
| console.error("Please provide a cocktail name as a command line argument."); | ||
| return; | ||
| } | ||
|
|
||
|
|
@@ -19,11 +112,13 @@ export async function main() { | |
| const outPath = path.join(__dirname, `./output/${cocktailName}.md`); | ||
|
|
||
| try { | ||
| // 1. Fetch data from the API at the given URL | ||
| // 2. Generate markdown content to match the examples | ||
| // 3. Write the generated content to a markdown file as given by outPath | ||
| const data = await fetchCocktailData(url); | ||
| validateCocktailData(data); | ||
|
|
||
| const markdown = `# Cocktail Recipes\n\n${generateMarkdownContent(data)}`; | ||
| await saveMarkdown(outPath, markdown); | ||
| } catch (error) { | ||
| // 4. Handle errors | ||
| console.error(`Something went wrong: ${error.message}`); | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Cocktail Recipes | ||
|
|
||
| ## Margarita | ||
|
|
||
|  | ||
|
|
||
| **Category**: Ordinary Drink | ||
|
|
||
| **Alcoholic**: Yes | ||
|
|
||
| ### Ingredients | ||
|
|
||
| - 1 1/2 oz Tequila | ||
| - 1/2 oz Triple sec | ||
| - 1 oz Lime juice | ||
| - Salt | ||
|
|
||
| ### Instructions | ||
|
|
||
| Rub the rim of the glass. | ||
|
|
||
| Serve in: Cocktail glass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, encapsulating your code in a function make it reusable