Conversation
espinozapelon285-del
approved these changes
Jul 9, 2026
Gayatri61
reviewed
Jul 23, 2026
| return productService.getAllProducts(); | ||
| } | ||
|
|
||
| @GetMapping("/search") |
There was a problem hiding this comment.
@YanaP1312 , @GetMapping ("/search") got replaced by @GetMapping (params = "color").
Why does endpoint got changed here ? Does exisiting searchProducts API working ? If there is frontend intergation then it will broke it.
Gayatri61
reviewed
Jul 23, 2026
| public List<Product> getAllProducts() { | ||
| return jdbcClient | ||
| .sql("SELECT id, title, price, category, image_url FROM products") | ||
| .sql("SELECT * FROM products ORDER BY id") |
There was a problem hiding this comment.
Its not a best practice to use * in select query even though im movement all colums getting fetched
Gayatri61
reviewed
Jul 23, 2026
| public Product findById(int id) { | ||
| return jdbcClient | ||
| .sql("SELECT id, title, price, category, image_url FROM products WHERE id = :id") | ||
| .sql("SELECT * FROM products WHERE id = :id") |
There was a problem hiding this comment.
Its not a best practice to use * in select query even though im movement all colums getting fetched
Gayatri61
reviewed
Jul 23, 2026
Gayatri61
left a comment
Gayatri61
left a comment
There was a problem hiding this comment.
Please check productController and ProductRepository file comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements all tasks from the assignment: