Skip to content

R. Yusup - #2

Open
Yusuprozimemet wants to merge 2 commits into
HackYourAssignment:mainfrom
Yusuprozimemet:main
Open

Yusuprozimemet wants to merge 2 commits into
HackYourAssignment:mainfrom
Yusuprozimemet:main

Conversation

@Yusuprozimemet

Copy link
Copy Markdown
  • Add B2Config and FileService for Backblaze S3 uploads, returning
    the public URL (endpoint/file/{bucket}/{key}) saved to image_url
  • Wire image upload/delete and size update through ProductService
  • Add findByColor (->>) and setSize (jsonb_set) in ProductRepository;
    make the row mapper a static final RowMapper
  • Expose imageUrl and details on ProductResponse
  • Add AWS SDK S3 dependencies (pom.xml) and b2.* config (application.yaml)

url: '${DB_URL}'
username: '${DB_USERNAME}'
password: '${DB_PASSWORD}'
url: jdbc:postgresql://localhost:5432/hyfshop

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove local host configuration

b2:
endpoint: https://s3.us-west-004.backblazeb2.com
region: us-west-004
access-key: YOUR_KEY_ID

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use hard code variable like access-key: YOUR_KEY_ID

@Gayatri61 Gayatri61 left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove local configuration from application.yml. Why there are screenshoots committed ? Please remove schreenshoots from commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants