Skip to content

Monerh A - #5

Open
Miuroro wants to merge 2 commits into
HackYourAssignment:mainfrom
Miuroro:main
Open

Miuroro wants to merge 2 commits into
HackYourAssignment:mainfrom
Miuroro:main

Conversation

@Miuroro

@Miuroro Miuroro commented May 21, 2026

Copy link
Copy Markdown

No description provided.

@mvcatsifma mvcatsifma left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong submission overall with both tasks compiling/running correctly, all Maven tests passing, and clean commit separation between Task 1 and Task 2.

Main improvement areas:

  • Order and Cache are package-private instead of explicitly public.
  • Size/Topping enums and Order are nested/inlined in unconventional ways instead of using separate files.
  • Main prints an extra "Hello Pizza!" line not present in the specification.
  • Field name cashe should be renamed to cache.
  • Some cache edge-case tests are missing, especially overwrite behavior.
  • Several comments restate obvious code behavior instead of explaining intent/reasoning.

For future assignments:

  • Prefer conventional Java project structure and file organization.
  • Keep public-facing model/API classes explicitly public.
  • Match program output exactly to the specification.
  • Expand tests to cover overwrite and edge-case behavior.
  • Use comments sparingly and focus on explaining non-obvious decisions.

Good overall implementation with only minor correctness and structure issues remaining.

@mvcatsifma mvcatsifma added Reviewed This assignment has been reivewed by a mentor and a feedback has been provided and removed Review in progress labels May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants