Conversation
mvcatsifma
self-requested a review
May 26, 2026 08:28
mvcatsifma
reviewed
May 26, 2026
mvcatsifma
left a comment
There was a problem hiding this comment.
Strong submission overall with both tasks compiling/running correctly, all Maven tests passing, and clean commit separation between Task 1 and Task 2.
Main improvement areas:
OrderandCacheare package-private instead of explicitlypublic.Size/Toppingenums andOrderare nested/inlined in unconventional ways instead of using separate files.Mainprints an extra"Hello Pizza!"line not present in the specification.- Field name
casheshould be renamed tocache. - Some cache edge-case tests are missing, especially overwrite behavior.
- Several comments restate obvious code behavior instead of explaining intent/reasoning.
For future assignments:
- Prefer conventional Java project structure and file organization.
- Keep public-facing model/API classes explicitly
public. - Match program output exactly to the specification.
- Expand tests to cover overwrite and edge-case behavior.
- Use comments sparingly and focus on explaining non-obvious decisions.
Good overall implementation with only minor correctness and structure issues remaining.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.