Skip to content

Yusup R. - #3

Open
Yusuprozimemet wants to merge 1 commit into
HackYourAssignment:mainfrom
Yusuprozimemet:main
Open

Yusuprozimemet wants to merge 1 commit into
HackYourAssignment:mainfrom
Yusuprozimemet:main

Conversation

@Yusuprozimemet

Copy link
Copy Markdown

No description provided.

@mvcatsifma mvcatsifma left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong submission overall with correct package structure, spec-matching receipt output, clean generic cache implementation, defensive copying, and good attention to detail. Both tasks compile/run cleanly and all tests pass.

Main improvement areas:

  • Cache tests miss a few important edge cases, especially overwrite behavior and removing missing keys.
  • Some test names contain small typos.
  • Commit history is reduced to a single squashed commit with a non-descriptive message.

For future assignments:

  • Expand unit tests to cover edge cases and state transitions.
  • Keep test naming clean and consistent.
  • Use meaningful commit messages that describe implemented changes.
  • Continue validating output carefully against the specification.

Very clean and complete implementation overall.

@mvcatsifma mvcatsifma added Reviewed This assignment has been reivewed by a mentor and a feedback has been provided and removed Review in progress labels May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants