Shadi A. - #1
Open
shmoonwalker wants to merge 9 commits into
Open
Shadi A.#1shmoonwalker wants to merge 9 commits into
shmoonwalker wants to merge 9 commits into
Conversation
…move, and clear functionalities
mvcatsifma
self-requested a review
May 26, 2026 08:28
mvcatsifma
reviewed
May 26, 2026
mvcatsifma
left a comment
There was a problem hiding this comment.
Solid implementation overall with correct enum pricing, clean Pizza/Order structure, a working generic Cache<T> implementation, and good use of streams and final fields.
Main improvement areas:
- Package declarations do not match the directory structure (
com/pizzacompany/...vspackage pizzacompany...). printReceipt()is missing the required receipt header and separator line from the specification.CacheTestsmisses several important edge cases, especially overwrite behavior, removing missing keys, and validatingsize()after removal.- One test is redundant and there is a small typo (
dobleCache). Cacheis package-private instead of explicitlypublic.
For future assignments:
- Always verify package declarations match the actual directory structure.
- Compare CLI/program output carefully against the exact specification.
- Expand unit tests to cover edge cases and state transitions.
- Remove redundant tests and keep naming/typos clean.
- Prefer explicit visibility modifiers for public APIs/classes.
Good overall structure and implementation quality with a few important correctness/details issues remaining.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 1 and 2 for week 3 Completed .