Skip to content

Monerh A - #4

Open
Miuroro wants to merge 1 commit into
HackYourAssignment:mainfrom
Miuroro:main
Open

Miuroro wants to merge 1 commit into
HackYourAssignment:mainfrom
Miuroro:main

Conversation

@Miuroro

@Miuroro Miuroro commented May 14, 2026

Copy link
Copy Markdown

No description provided.

@mvcatsifma mvcatsifma left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall class structure is mostly in the right direction, but the submission currently has several critical issues and does not meet basic requirements.

Main improvement areas:

  • The code does not compile because Student and Mentor call super() after incrementing a counter; in Java, super() must be the first constructor statement.
  • viewAllStudents() can crash with ArrayIndexOutOfBoundsException because courses[i] is incorrectly indexed together with students[i].
  • Student.toString() is incomplete and does not print the expected average/status information.
  • addCourse() can leave invalid Live Cohort courses in the array if mentor validation fails.
  • Several design choices weaken the model, including package-private/public fields, Reportable.generateReport() returning void, and overly broad exception handling.
  • Leftover Week 1 files are still included in the submission.

For future assignments:

  • Always compile and run the full project before submission.
  • Test all menu paths and invalid/error flows carefully.
  • Keep fields private by default and expose behavior through methods.
  • Match interface method signatures exactly with the specification.
  • Remove unused or leftover files before submitting.

This submission needs compile/runtime fixes before it is ready.

@mvcatsifma mvcatsifma added Reviewed This assignment has been reivewed by a mentor and a feedback has been provided and removed Review in progress labels May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants