Conversation
mvcatsifma
self-requested a review
May 22, 2026 12:25
mvcatsifma
reviewed
May 22, 2026
mvcatsifma
left a comment
There was a problem hiding this comment.
The overall class structure is mostly in the right direction, but the submission currently has several critical issues and does not meet basic requirements.
Main improvement areas:
- The code does not compile because
StudentandMentorcallsuper()after incrementing a counter; in Java,super()must be the first constructor statement. viewAllStudents()can crash withArrayIndexOutOfBoundsExceptionbecausecourses[i]is incorrectly indexed together withstudents[i].Student.toString()is incomplete and does not print the expected average/status information.addCourse()can leave invalid Live Cohort courses in the array if mentor validation fails.- Several design choices weaken the model, including package-private/public fields,
Reportable.generateReport()returningvoid, and overly broad exception handling. - Leftover Week 1 files are still included in the submission.
For future assignments:
- Always compile and run the full project before submission.
- Test all menu paths and invalid/error flows carefully.
- Keep fields
privateby default and expose behavior through methods. - Match interface method signatures exactly with the specification.
- Remove unused or leftover files before submitting.
This submission needs compile/runtime fixes before it is ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.