Yusup R. - #2
Open
Yusuprozimemet wants to merge 3 commits into
Open
Yusup R.#2Yusuprozimemet wants to merge 3 commits into
Yusuprozimemet wants to merge 3 commits into
Conversation
…well, no service layer yet. codes are tested with main, looks fine for now.
…nteractive CLI yet.
mvcatsifma
self-requested a review
May 22, 2026 12:13
mvcatsifma
reviewed
May 22, 2026
mvcatsifma
left a comment
There was a problem hiding this comment.
Strong overall submission with correct architecture, good use of inheritance/polymorphism, a properly structured exception hierarchy, and clean CLI/error handling.
Main improvement areas:
getCourses()currently returns the full backing array including trailingnullvalues, which can lead toNullPointerExceptions when iterating enrolled courses.- The project runs correctly in IntelliJ, but the current package/directory structure causes issues when compiling/running directly from the command line.
- Several fields in
Courseare exposed asprotectedinstead ofprivate, reducing encapsulation. - Commit messages describe progress/state rather than implemented changes.
- Public methods are missing Javadoc comments.
For future assignments:
- Be careful about exposing internal arrays directly — prefer defensive copies.
- Test both IDE-based and command-line compilation/runtime flows when working with Java packages.
- Keep encapsulation strict by default (
privatefirst). - Use short, descriptive commit messages focused on implemented changes.
- Start building the habit of documenting public APIs with Javadoc.
Very solid implementation overall with strong OOP fundamentals and good exception handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.