Skip to content

Yusup R. - #2

Open
Yusuprozimemet wants to merge 3 commits into
HackYourAssignment:mainfrom
Yusuprozimemet:main
Open

Yusuprozimemet wants to merge 3 commits into
HackYourAssignment:mainfrom
Yusuprozimemet:main

Conversation

@Yusuprozimemet

Copy link
Copy Markdown

No description provided.

@mvcatsifma mvcatsifma left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong overall submission with correct architecture, good use of inheritance/polymorphism, a properly structured exception hierarchy, and clean CLI/error handling.

Main improvement areas:

  • getCourses() currently returns the full backing array including trailing null values, which can lead to NullPointerExceptions when iterating enrolled courses.
  • The project runs correctly in IntelliJ, but the current package/directory structure causes issues when compiling/running directly from the command line.
  • Several fields in Course are exposed as protected instead of private, reducing encapsulation.
  • Commit messages describe progress/state rather than implemented changes.
  • Public methods are missing Javadoc comments.

For future assignments:

  • Be careful about exposing internal arrays directly — prefer defensive copies.
  • Test both IDE-based and command-line compilation/runtime flows when working with Java packages.
  • Keep encapsulation strict by default (private first).
  • Use short, descriptive commit messages focused on implemented changes.
  • Start building the habit of documenting public APIs with Javadoc.

Very solid implementation overall with strong OOP fundamentals and good exception handling.

@mvcatsifma mvcatsifma added Reviewed This assignment has been reivewed by a mentor and a feedback has been provided and removed Review in progress labels May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants