Shadi A. - #1
Open
shmoonwalker wants to merge 7 commits into
Open
Shadi A.#1shmoonwalker wants to merge 7 commits into
shmoonwalker wants to merge 7 commits into
Conversation
…ent` classes with roles and enrolment logic
…h enrolment, progress tracking, and reporting logic
…nt features including enrolment, progress tracking, and reporting
…nt features including enrolment, progress tracking, and reporting
…nt features including enrolment, progress tracking, and reporting
Feature/academy course platform
mvcatsifma
self-requested a review
May 22, 2026 12:35
mvcatsifma
reviewed
May 22, 2026
There was a problem hiding this comment.
Excellent submission. The project compiles and runs cleanly, the architecture is solid, and the code shows strong OOP fundamentals. Polymorphism, inheritance, interfaces, and the custom exception hierarchy are all used well, and the CLI flow is readable and stable.
Main improvement areas:
- Duplicate enrolment is checked by course name instead of course ID.
- Some getters return backing arrays with trailing
nullvalues. - ID lookup is case-sensitive in a few places.
- Public methods would benefit from Javadoc.
For future assignments:
- Compare entities by stable IDs, not names.
- Return defensive/trimmed copies from array-backed collections.
- Keep testing both happy paths and edge cases.
- Start documenting public APIs.
Strong work overall.
mvcatsifma
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finished week two assignments