Conversation
dilero
reviewed
Jul 13, 2026
|
|
||
| public LoginResponse login(LoginRequest request) { | ||
| throw new UnsupportedOperationException("TODO: implement login"); | ||
| Authentication authentication = authenticationManager.authenticate( |
There was a problem hiding this comment.
authenticationManager.authenticate() throws AuthenticationException if credentials are invalid. Make sure you're handling that somewhere (either here with a try-catch or globally with a @ControllerAdvice) so the user gets a clean 401 response instead of a 500.
dilero
reviewed
Jul 13, 2026
| throw new UnsupportedOperationException("TODO: implement registration"); | ||
|
|
||
| String encodedPassword = passwordEncoder.encode(request.password()); | ||
| User user = new User(UUID.randomUUID().toString(), request.username(), encodedPassword); |
There was a problem hiding this comment.
Right now if someone registers with an existing username, you'll likely get an unhandled database exception. Add a check:
if (userRepository.findByUsername(request.username()).isPresent()) {
throw new ResponseStatusException(HttpStatus.CONFLICT, "Username already taken");
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented JWT-based authentication using Spring Security.
Changes
SecurityConfig: filter chain, BCrypt (strength 12), stateless sessions./register,/loginpublic;/logout,/profileprotected.AppUserDetailsServiceconnectsUserRepositoryto Spring Security.JwtServicegenerates and validates tokens.JwtAuthenticationFilterchecks the token on each request./logoutis stateless.