Skip to content

Create BinarySearch.cpp#79

Open
akshikamudgal wants to merge 7 commits into
HackClubRAIT:mainfrom
akshikamudgal:main
Open

Create BinarySearch.cpp#79
akshikamudgal wants to merge 7 commits into
HackClubRAIT:mainfrom
akshikamudgal:main

Conversation

@akshikamudgal

@akshikamudgal akshikamudgal commented Oct 4, 2021

Copy link
Copy Markdown

What is the change?

Added the binary search documentation

Related issue?

closes: #31

Checklist:

Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

  • I have followed the Code of Conduct.
  • I have checked there aren't other open Pull Requests for the same update/change.
  • I have you tested the code before submission.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I'm Hacktoberfest'21 contributor.

@siddhi-244

Copy link
Copy Markdown
Member

this is a documentation repository so make sure you submit files with .md extension

@akshikamudgal

Copy link
Copy Markdown
Author

this is a documentation repository so make sure you submit files with .md extension

Yes, I have done the required changes.

@siddhi-244 siddhi-244 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's plagiarized. Write in your own words.

@akshikamudgal

Copy link
Copy Markdown
Author

It's plagiarized. Write in your own words.

Done

@siddhi-244

Copy link
Copy Markdown
Member

It's already there. Please try to improve that doc !

@akshikamudgal

Copy link
Copy Markdown
Author

It's already there. Please try to improve that doc !

Everything else is present but the code provided is in python and java, so I have to add C++ ?

@siddhi-244

Copy link
Copy Markdown
Member

It's already there. Please try to improve that doc !

Everything else is present but the code provided is in python and java, so I have to add C++ ?

Yaa you can !

@akshikamudgal

Copy link
Copy Markdown
Author

It's already there. Please try to improve that doc !

Everything else is present but the code provided is in python and java, so I have to add C++ ?

Yaa you can !

Updated both #31 and #74 but it is taking both commits together, if it should be done separately suggest me the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Binary Search

2 participants