Skip to content

Completing reports migration - #41

Merged
max-ostapenko merged 32 commits into
mainfrom
standard_reports
Jul 31, 2025
Merged

Completing reports migration#41
max-ostapenko merged 32 commits into
mainfrom
standard_reports

Conversation

@max-ostapenko

@max-ostapenko max-ostapenko commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

Docs
I added only crawl lenses support to the reports, CrUX will follow after we migrate these.

Examples of bytesTotal (cached on CDN):

Comment thread definitions/output/reports/reports_dynamic.js Outdated
@max-ostapenko
max-ostapenko marked this pull request as ready for review January 7, 2025 06:24
@max-ostapenko
max-ostapenko requested a review from Copilot January 7, 2025 06:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (5)

definitions/output/reports/reports_dynamic.js:5

  • Replace the hardcoded date with a constant or variable to avoid magic numbers.
const startDate = '2024-12-01' // constants.currentMonth;

definitions/output/reports/reports_dynamic.js:6

  • Replace the hardcoded date with a constant or variable to avoid magic numbers.
const endDate = '2024-12-01' // constants.currentMonth;

includes/reports.js:25

  • The term 'lense' is incorrectly spelled. It should be 'lens'.
date = '${params.date}' ${params.devRankFilter} ${params.lense.sql} AND

includes/reports.js:51

  • The term 'lense' is incorrectly spelled. It should be 'lens'.
date = '${params.date}' ${params.devRankFilter} ${params.lense.sql} AND

infra/bigquery-export/reports.js:46

  • Modifying this.storagePath directly can lead to unintended side effects. Consider resetting this.storagePath to its original value after the export is completed.
this.storagePath = this.storagePath + `${exportData.lense}/`

Comment thread infra/bigquery-export/reports.js Outdated
@max-ostapenko
max-ostapenko marked this pull request as draft January 7, 2025 22:29
@max-ostapenko
max-ostapenko marked this pull request as ready for review July 31, 2025 09:08
@max-ostapenko
max-ostapenko requested a review from tunetheweb July 31, 2025 09:47
@max-ostapenko

Copy link
Copy Markdown
Contributor Author

@tunetheweb would this be easier to maintain?

@tunetheweb tunetheweb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread .github/workflows/ci.yaml Outdated
Comment thread includes/reports.js
Comment on lines +95 to +97
drupal: 'AND \'Drupal\' IN UNNEST(technologies.technology)',
magento: 'AND \'Magento\' IN UNNEST(technologies.technology)',
wordpress: 'AND \'WordPress\' IN UNNEST(technologies.technology)'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to think how this works for reports that don't look at page dataset. But maybe that's only CrUX and that's why you've excluded those for now?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we'll start using the new approach faster this way + need to identify all additional customizations required before further adjustments.

Maybe it will be easier to get breakdowns by 8 lenses per report in one query (as we do in tech report) instead of 8.

@max-ostapenko
max-ostapenko merged commit ce50c15 into main Jul 31, 2025
21 checks passed
@max-ostapenko
max-ostapenko deleted the standard_reports branch July 31, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants