Skip to content

fix(ui): sync EtaPhi view with 3D view visibility and cuts (#926) - #966

Open
DashratRajpurohit wants to merge 1 commit into
HSF:mainfrom
DashratRajpurohit:fix/926-eta-phi-ui-sync
Open

fix(ui): sync EtaPhi view with 3D view visibility and cuts (#926)#966
DashratRajpurohit wants to merge 1 commit into
HSF:mainfrom
DashratRajpurohit:fix/926-eta-phi-ui-sync

Conversation

@DashratRajpurohit

Copy link
Copy Markdown

Summary

Fixes #926: Ensures the Eta-Phi energy map overlay dynamically updates in real time when event data collections/objects (tracks, jets, MET, calo cells) are toggled on/off or when cut filters (e.g. pT cuts) are adjusted in the main 3D view.

Changes Made

  • EventDisplay & UI Managers (phoenix-event-display):
    • Added listenToStateChange and triggerStateChange event listener pipeline.
    • Added isCollectionVisible(collectionName) and isItemVisible(collectionName, item) helpers to evaluate 3D object visibility and active Cut attribute ranges.
    • Wired onStateChange callback triggers in PhoenixMenuUI and DatGUIMenuUI when visibility checkboxes or cut range sliders are moved.
  • EtaPhiPanelOverlayComponent (phoenix-ng):
    • Subscribed to listenToStateChange in ngOnInit() to trigger rebuildData().
    • Updated buildGrid() and buildMarkers() for Jets, Muons, Electrons, Photons, Tracks, and MissingEnergy to exclude hidden collections and items failing active cut conditions.
  • Unit Tests:
    • Added unit test suite eta-phi-panel-overlay.component.test.ts verifying subscription and filter behavior.

Test Plan

  • Unit tests added in eta-phi-panel-overlay.component.test.ts.
  • Tested toggling collection checkboxes and adjusting pT cut sliders; confirmed objects dynamically appear/disappear on the Eta-Phi canvas matching the 3D scene.

@EdwardMoyse

Copy link
Copy Markdown
Member

Thank you for your PR! This is failing the CI because of commits not following the conventions (see the contributing doc for details) but more importantly, there is an actual issue with the code. Please have a look?

@DashratRajpurohit
DashratRajpurohit force-pushed the fix/926-eta-phi-ui-sync branch from 09a9648 to c63d9f1 Compare July 27, 2026 16:14
@DashratRajpurohit

Copy link
Copy Markdown
Author

Hi @EdwardMoyse! Thank you for the review!

I have resolved both issues:

  1. TypeScript Build Error Fix: Imported missing SceneManager in packages/phoenix-event-display/src/event-display.ts, which was causing error TS2552: Cannot find name 'SceneManager'.
  2. Commit Convention Fix: Amended the commit header to follow the repo's conventional commit format (fix(event-display): sync eta-phi view with 3d view visibility and cuts).

The branch has been updated and force-pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EtaPhi view does not update with the 3D view

2 participants