fix(ui): sync EtaPhi view with 3D view visibility and cuts (#926) - #966
Open
DashratRajpurohit wants to merge 1 commit into
Open
fix(ui): sync EtaPhi view with 3D view visibility and cuts (#926)#966DashratRajpurohit wants to merge 1 commit into
DashratRajpurohit wants to merge 1 commit into
Conversation
Member
|
Thank you for your PR! This is failing the CI because of commits not following the conventions (see the contributing doc for details) but more importantly, there is an actual issue with the code. Please have a look? |
DashratRajpurohit
force-pushed
the
fix/926-eta-phi-ui-sync
branch
from
July 27, 2026 16:14
09a9648 to
c63d9f1
Compare
Author
|
Hi @EdwardMoyse! Thank you for the review! I have resolved both issues:
The branch has been updated and force-pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #926: Ensures the Eta-Phi energy map overlay dynamically updates in real time when event data collections/objects (tracks, jets, MET, calo cells) are toggled on/off or when cut filters (e.g. pT cuts) are adjusted in the main 3D view.
Changes Made
EventDisplay& UI Managers (phoenix-event-display):listenToStateChangeandtriggerStateChangeevent listener pipeline.isCollectionVisible(collectionName)andisItemVisible(collectionName, item)helpers to evaluate 3D object visibility and activeCutattribute ranges.onStateChangecallback triggers inPhoenixMenuUIandDatGUIMenuUIwhen visibility checkboxes or cut range sliders are moved.EtaPhiPanelOverlayComponent(phoenix-ng):listenToStateChangeinngOnInit()to triggerrebuildData().buildGrid()andbuildMarkers()forJets,Muons,Electrons,Photons,Tracks, andMissingEnergyto exclude hidden collections and items failing active cut conditions.eta-phi-panel-overlay.component.test.tsverifying subscription and filter behavior.Test Plan
eta-phi-panel-overlay.component.test.ts.