HCKTest: Update results files after package generation#979
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the test runner to reload tests and update results after creating the project package, ensuring the final report is correct. It introduces a new method update_tests_and_results and propagates any exceptions raised during this step. The reviewer suggests adding a Sorbet type signature to the new method to maintain type safety and consistency.
There was a problem hiding this comment.
Pull request overview
This PR adds a post-package-creation step to HCKTest's auto-run flow that refreshes test state and regenerates the results report and JUnit XML. The motivation is that filters applied during HLK project package creation may include filters for the last test that weren't reflected in earlier result generations, so reloading tests and regenerating the final report ensures the saved results are accurate.
Changes:
- Added
Tests#update_tests_and_resultsthat reloads tests and regenerates the result report and JUnit output. - Invoked the new method after
create_project_packageinHCKTest#auto_run, guarded byrescue2return. - Refactored exception propagation to iterate over
[ex1, ex2, ex3, ex4]instead of separateraisestatements.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/engines/hcktest/tests.rb | Adds update_tests_and_results helper that refreshes tests and regenerates result report and JUnit files. |
| lib/engines/hcktest/hcktest.rb | Calls the new helper after package creation and includes its exception in propagation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
No description provided.