Skip to content

HCKTest: Update results files after package generation#979

Merged
kostyanf14 merged 1 commit into
HCK-CI:masterfrom
kostyanf14:upd-res
May 28, 2026
Merged

HCKTest: Update results files after package generation#979
kostyanf14 merged 1 commit into
HCK-CI:masterfrom
kostyanf14:upd-res

Conversation

@kostyanf14
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test runner to reload tests and update results after creating the project package, ensuring the final report is correct. It introduces a new method update_tests_and_results and propagates any exceptions raised during this step. The reviewer suggests adding a Sorbet type signature to the new method to maintain type safety and consistency.

Comment thread lib/engines/hcktest/tests.rb
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a post-package-creation step to HCKTest's auto-run flow that refreshes test state and regenerates the results report and JUnit XML. The motivation is that filters applied during HLK project package creation may include filters for the last test that weren't reflected in earlier result generations, so reloading tests and regenerating the final report ensures the saved results are accurate.

Changes:

  • Added Tests#update_tests_and_results that reloads tests and regenerates the result report and JUnit output.
  • Invoked the new method after create_project_package in HCKTest#auto_run, guarded by rescue2return.
  • Refactored exception propagation to iterate over [ex1, ex2, ex3, ex4] instead of separate raise statements.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lib/engines/hcktest/tests.rb Adds update_tests_and_results helper that refreshes tests and regenerates result report and JUnit files.
lib/engines/hcktest/hcktest.rb Calls the new helper after package creation and includes its exception in propagation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
@kostyanf14 kostyanf14 merged commit db4377f into HCK-CI:master May 28, 2026
9 checks passed
@kostyanf14 kostyanf14 deleted the upd-res branch May 28, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants