Skip to content

Add JUnit property 'report_generation_time'#973

Merged
kostyanf14 merged 1 commit into
HCK-CI:masterfrom
kostyanf14:junit-gen-time
May 26, 2026
Merged

Add JUnit property 'report_generation_time'#973
kostyanf14 merged 1 commit into
HCK-CI:masterfrom
kostyanf14:junit-gen-time

Conversation

@kostyanf14
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
Copilot AI review requested due to automatic review settings May 25, 2026 17:29
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the project_properties method in lib/junit.rb by splitting it into project_properties and engine_properties, adding a report_generation_time field, and merging them in run_properties. Feedback suggests optimizing the hash merging by passing multiple arguments to Hash#merge to avoid creating intermediate hashes, and using UTC time (Time.now.utc.iso8601) for the report generation timestamp to ensure consistency across different runner environments.

Comment thread lib/junit.rb
Comment thread lib/junit.rb
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates AutoHCK’s JUnit report generation to include a new report_generation_time property in the <properties> section, and refactors how JUnit properties are assembled by splitting engine-specific fields into a separate hash.

Changes:

  • Add JUnit property report_generation_time (ISO8601 timestamp).
  • Split project_properties vs engine_properties, and include engine_properties in run_properties.
  • Introduce emission of engine_test_steps_count into the generated JUnit properties via the new merge behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/junit.rb
Comment thread lib/junit.rb
Comment thread lib/junit.rb
@kostyanf14 kostyanf14 merged commit d2b8316 into HCK-CI:master May 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants