Add JUnit property 'report_generation_time'#973
Conversation
Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
There was a problem hiding this comment.
Code Review
This pull request refactors the project_properties method in lib/junit.rb by splitting it into project_properties and engine_properties, adding a report_generation_time field, and merging them in run_properties. Feedback suggests optimizing the hash merging by passing multiple arguments to Hash#merge to avoid creating intermediate hashes, and using UTC time (Time.now.utc.iso8601) for the report generation timestamp to ensure consistency across different runner environments.
There was a problem hiding this comment.
Pull request overview
This PR updates AutoHCK’s JUnit report generation to include a new report_generation_time property in the <properties> section, and refactors how JUnit properties are assembled by splitting engine-specific fields into a separate hash.
Changes:
- Add JUnit property
report_generation_time(ISO8601 timestamp). - Split
project_propertiesvsengine_properties, and includeengine_propertiesinrun_properties. - Introduce emission of
engine_test_steps_countinto the generated JUnit properties via the new merge behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.