VIRTWINKVM-2071: Automate Hardware-enforced Stack Protection Compatibility Test#924
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables the EDID, HPD, and HSP tests for the viogpu driver by automating manual UI interactions using new AutoIt scripts. The driver configuration was updated to include AutoIt as a dependency and specify the necessary pre-test and post-test commands. Review feedback highlights that escaped parentheses in the test name strings within the JSON configuration will cause matching failures in the test engine. Furthermore, the HSP watcher script requires improvements to handle multiple command prompt windows correctly and to verify window activation before sending input to avoid side effects.
elizashurov
force-pushed
the
VIRTWINKVM-2071
branch
2 times, most recently
from
716c112 to
e23584e
Compare
kostyanf14
changed the title
elizashurov
force-pushed
the
VIRTWINKVM-2071
branch
from
e23584e to
37bb026
Compare
@kostyanf14 @YanVugenfirer Test passed |
Enable guest_reboot for pre_test_commands and post_test_commands Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
…ility Test Use an AutoIt watcher script to automate the HSP test across all drivers that previously rejected it. An HKLM Run key registers the watcher to start on user logon, and a guest_reboot activates it before the test begins. - Add HSP tests_config to hcktest.json with pre/post commands to upload, register, and clean up the AutoIt watcher - Add autoit to HLK2022.json kit-level extra_software Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
elizashurov
force-pushed
the
VIRTWINKVM-2071
branch
from
37bb026 to
2b5f0e9
Compare
|
@zjmletang You may be interested in this change |
|
@kostyanf14 @elizashurov Thanks a lot, this is really great. We used to skip this test and rely on an errata for WHQL, so it’s nice that I’ll be able to run it now. |
|
@zjmletang but errata = manual review = additional time, that's why we try to automate everything |
4 participants
Use an AutoIt watcher script to automate the HSP test across all
drivers that previously rejected it. An HKLM Run key launches the
watcher in the interactive session, with a reboot to activate it.
upload, register, and clean up the AutoIt watcher
Depends on: