feat: add global library search and safe release upgrades (#12) - #36
feat: add global library search and safe release upgrades (#12)#36mahoshojoHCG wants to merge 21 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2c685c5d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
# Conflicts: # SecondDimensionWatcherReDive.Client/src/components/AppHeader.tsx # SecondDimensionWatcherReDive.Client/src/i18n/locales/en/common.json # SecondDimensionWatcherReDive.Client/src/i18n/locales/ja/common.json # SecondDimensionWatcherReDive.Client/src/i18n/locales/zh-CN/common.json # SecondDimensionWatcherReDive/Controllers/External/AppJsonSerializerContext.cs # SecondDimensionWatcherReDive/Models/ApplicationContext.cs # SecondDimensionWatcherReDive/Program.cs # SecondDimensionWatcherReDive/Repositories/AnimationInfoRepository.cs # SecondDimensionWatcherReDive/Repositories/MetadataReviewRepository.cs # SecondDimensionWatcherReDive/Services/SyncFeed.cs
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 330b8c29c9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81903d5444
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52fbe5e3bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07d669e75b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab6432b7d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87cc75f68d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3a60fb235
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b282862af4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@codex review |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 337763cadd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eea53b1ce2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let automatic = current.ReleaseScoreReasonsJson != null && | ||
| candidate.SourceFeedId != null && | ||
| context.SubscriptionAutomationPolicies.Any(policy => | ||
| policy.FeedId == candidate.SourceFeedId && | ||
| policy.EnableVersionUpgrade && | ||
| candidate.ReleaseScore - current.ReleaseScore >= | ||
| policy.MinimumUpgradeScore) |
There was a problem hiding this comment.
When automatic upgrades are enabled, these stored scores are not comparable because each release is scored once using the policy that existed at its own ingestion time. For example, after adding a subtitle group to a policy, a new release identical to the incumbent can receive an extra 50 points while the incumbent retains its old score, satisfying MinimumUpgradeScore and triggering an unnecessary automatic replacement; releases from different feeds have the same problem. Rescore both releases using one current policy before evaluating the upgrade.
Useful? React with 👍 / 👎.
| if (result.Season is { } inferredSeason) | ||
| { | ||
| var expectedEpisodeCount = await tmdbTool.GetExpectedEpisodeCountAsync( | ||
| tmdbIdInt, | ||
| inferredSeason, | ||
| cancellationToken); | ||
| if (expectedEpisodeCount is not null) | ||
| item = item with { ExpectedEpisodeCount = expectedEpisodeCount }; |
There was a problem hiding this comment.
When inference is retried and identifies a different show or season, item still carries the previous ExpectedEpisodeCount, and this branch replaces it only when the new TMDB lookup returns a non-null count. A transient lookup failure, an absent season, or a newly null season therefore leaves the old count attached to the new metadata; BuildIntegrity then takes the maximum persisted count and reports nonexistent episodes as missing. Clear the count before inference and assign the lookup result even when it is null.
Useful? React with 👍 / 👎.
1 participant
Summary
Boundaries
Closes #12