Skip to content

feat: require approval for AI write actions - #27

Open
mahoshojoHCG wants to merge 2 commits into
mainfrom
codex/issue-8
Open

feat: require approval for AI write actions#27
mahoshojoHCG wants to merge 2 commits into
mainfrom
codex/issue-8

Conversation

@mahoshojoHCG

Copy link
Copy Markdown
Contributor

Summary

  • declare explicit read-only, mutating, or destructive risk metadata for every AI tool and classify mixed tools by exact action
  • replace direct chat write execution with encrypted, user/conversation-bound pending actions, one-time atomic approval claims, expiration, replay protection, and queryable redacted audit events
  • stream approval_required events and add reconnect-safe approve/reject cards with server-enforced second confirmation for destructive actions
  • redact protected write parameters from persisted chat history and application logs
  • add an EF Core migration plus security coverage for prompt injection, tampering, rejection, expiration, invalid conversations, concurrent approval, reconnect, and replay

Validation

  • dotnet test SecondDimensionWatcherReDive.slnx --no-restore (419 passed)
  • yarn build
  • dotnet tool run dotnet-ef migrations has-pending-model-changes ... --no-build

Closes #8

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-29T13:43:44.871567Z 03f142e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 03f142eb4f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread SecondDimensionWatcherReDive/Repositories/ChatActionRepository.cs
Comment thread Plugins/SecondDimensionWatcherReDive.Chat/ChatActionService.cs
Comment thread Plugins/SecondDimensionWatcherReDive.Chat/ChatActionService.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P0] 为 AI 写操作增加服务端审批与审计

1 participant