Skip to content

fix(docs-site): use site's external-link icon in cookie banner#2290

Merged
aaronlee777 merged 1 commit into
mainfrom
al/fix/cookies-external-link-icon
Jun 26, 2026
Merged

fix(docs-site): use site's external-link icon in cookie banner#2290
aaronlee777 merged 1 commit into
mainfrom
al/fix/cookies-external-link-icon

Conversation

@aaronlee777

Copy link
Copy Markdown
Contributor

Summary

The cookie consent plugin ships an inline box-and-arrow SVG next to external links in its description text (Privacy Notice). Swap it for the diagonal-arrow glyph already used throughout the docs site — navbar GitHub link, footer external links, etc. — so external-link affordances stay visually consistent.

Mechanism:

  • Hides the plugin's .cookie-consent-external-link-icon SVG via display: none
  • Adds an ::after pseudo-element on .cookie-consent-description a[href*='://'] using the same M7 17 17 7 / M7 7h10v10 mask, currentColor fill, 0.6 → 1.0 opacity on hover — same recipe as .footer__link-item[href*='://']::after.

Test plan

  • Run docs-site dev server, clear cookie preference so the rail re-appears, hover the "Privacy Notice" link in the description, and confirm the icon matches the navbar/footer external-link icon style and color in both light and dark mode.

🤖 Generated with Claude Code

Replace the cookie consent plugin's inline box-and-arrow SVG with the
diagonal-arrow glyph we use elsewhere (navbar GitHub link, footer
external links). Hides the plugin's SVG and renders the icon via an
`::after` mask-image on the description's external links.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@aaronlee777 aaronlee777 requested a review from a team as a code owner June 26, 2026 20:33
@aaronlee777 aaronlee777 enabled auto-merge June 26, 2026 20:35
@aaronlee777 aaronlee777 added this pull request to the merge queue Jun 26, 2026
Merged via the queue into main with commit 687726c Jun 26, 2026
31 checks passed
@aaronlee777 aaronlee777 deleted the al/fix/cookies-external-link-icon branch June 26, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants