Skip to content

refactor(StateTaxes): flatten form into a single evenly-spaced stack #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aaronlee777 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor(StateTaxes): flatten form into a single evenly-spaced stack #2245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 16 additions & 32 deletions src/components/Company/StateTaxes/StateTaxesForm/Form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,42 +1,26 @@
import { useTranslation } from 'react-i18next'
import { Fragment } from 'react/jsx-runtime'
import { useStateTaxesForm } from './context'
import { toRhfKey } from './rhfKey'
import { QuestionInput } from '@/components/Common/TaxInputs/TaxInputs'
import { useLocaleDateFormatter } from '@/contexts/LocaleProvider/useLocale'
import { useComponentContext } from '@/contexts/ComponentAdapter/useComponentContext'
import { Flex } from '@/components/Common/Flex/Flex'

/** @internal */
export function Form() {
const { t } = useTranslation('Company.StateTaxes', { keyPrefix: 'form' })
const dateFormatter = useLocaleDateFormatter()
const { stateTaxRequirements } = useStateTaxesForm()
const Components = useComponentContext()

return stateTaxRequirements.requirementSets?.map(
({ requirements, label, effectiveFrom, key }) => (
<Fragment key={key}>
<div>
<Components.Heading as="h3">{label}</Components.Heading>
{effectiveFrom && (
<Components.Text size="sm">
{t('effectiveFromLabel', { date: dateFormatter.format(new Date(effectiveFrom)) })}
</Components.Text>
)}
</div>
{requirements?.map(requirement => {
return (
<QuestionInput
requirement={{
...requirement,
key: `${key}.${toRhfKey(requirement.key as string)}`,
}}
questionType={requirement.metadata?.type ?? 'Text'}
key={requirement.key}
/>
)
})}
</Fragment>
),
return (
<Flex flexDirection="column" gap={20}>
{stateTaxRequirements.requirementSets?.flatMap(({ requirements, key }) =>
requirements?.map(requirement => (
<QuestionInput
key={`${key}.${requirement.key}`}
requirement={{
...requirement,
key: `${key}.${toRhfKey(requirement.key as string)}`,
}}
questionType={requirement.metadata?.type ?? 'Text'}
/>
)),
)}
</Flex>
)
}
Loading