fix(session): Prevent PDO serialization fatal on MODX 3.2.2+ - #18
Open
Ibochkarev wants to merge 1 commit into
Open
fix(session): Prevent PDO serialization fatal on MODX 3.2.2+#18Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Putting $this into scriptProperties left a FetchIt→modX→PDO graph in the session store, which PHP 8.3 cannot serialize on session_write_close after MODX 3.2.2. Centralize save/load and strip non-serializable values. Fixes GulomovCreative#17 Co-Authored-By: Cursor <cursoragent@cursor.com>
Ibochkarev
marked this pull request as ready for review
July 21, 2026 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop putting the FetchIt instance into FormIt/snippet
scriptPropertiesand harden how action properties are persisted for AJAX submits.On MODX 3.2.2 + PHP 8.3,
session_write_close()fatals withSerialization of 'PDO' is not allowedwhenever a frontend template calls FetchIt. The instance holdsmodX, which holds PDO; once that graph lands in$_SESSION, the response cannot finish. Admin still works because it never runs the snippet.Also centralize save/load in
saveActionProperties()/getActionProperties()and strip objects/resources before writing to session or cache, so the same failure cannot return via Fenom or other object-bearing props.Breaking for custom snippets:
$scriptProperties['FetchIt']is no longer injected. Use$modx->services->get('FetchIt')instead (already registered inbootstrap.php).Fixes #17