feat(task): read descriptions from piped stdin - #62
Merged
Conversation
Contributor
Author
Triage UpdateFixed
False Positive
Deferred
Remaining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task addand baretask modifywhen no description text was supplied as CLI argsmodifyconfirmation prompts when modification args are presentVerification
make -C build-test task_executable -j4TASK_USE_PATH=1 PATH="$PWD/build-test/src:$PATH" python3 test/add.test.pyTASK_USE_PATH=1 PATH="$PWD/build-test/src:$PATH" python3 test/modify.test.py -k TestModifyDescriptionInput1 2 modify priority:Hwithinput="All\n"keeps descriptions unchanged and applies priorityflicknote-cli/src/commands/add.rs,modify.rs,replace.rs, andutil.rsNote: full
test/modify.test.pystill has an unrelated existing failure inTestBug1306:project:PROJ add fooexits withProject not found: PROJin this fork.