refactor: move data operations into the daemon - #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safety and races
Verification
Authorized dev smoke confirmed invalid DATABASE_URL still starts local protocol 2, note add → immediate detail/MCP get, text upload, editor round-trip, project CRUD upload, empty ps_crud, and advancing WAL checkpoint. Test notes/project were archived and the original installed daemon was restored. The dev share endpoint returned an external 404, so live share/unshare could not be completed; application/IPC share contracts remain covered by automated tests.
Observed pre-existing follow-up: an immediate note add against a just-created project can race the project's asynchronous upload and receive backend FK 23503. Recorded as FlickNote deferable #1791; no arbitrary delay or temporary upload barrier was added to this refactor.