refactor(resources): consolidate deployment helpers and remove duplication - #10
Merged
Merged
Conversation
…ation - Add common/names.go with centralized KongConfigMapName (was duplicated) - Add ReloaderAnnotation constant to common/labels.go - Create deployments/helpers.go with: - ProbeConfig type and BuildHTTPProbe/BuildLivenessProbe/BuildReadinessProbe - NormalizeReplicas, AddImagePullSecrets, BuildDatabaseEnv helpers - Update all deployment builders to use new helpers - Add generic reconcileServiceComponent helper to controller - Refactor 4 service reconcilers (Auth, Rest, Studio, Meta) to use helper Co-Authored-By: Claude <noreply@anthropic.com>
birdmanmandbir
force-pushed
the
refactor/consolidate-deployment-helpers
branch
from
January 3, 2026 05:23
39e3353 to
aee2e40
Compare
- Add newServiceReconcileConfig constructor to enforce required fields at compile time instead of runtime validation - Use BuildDatabaseEnv helper in auth.go and rest.go to reduce duplication - Add doc comments to ProbeConfig fields with typical value ranges
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KongConfigMapNamefunction (was defined in both configmaps/ and deployments/)ReloaderAnnotationconstant to replace hardcoded stringsBuildHTTPProbe/BuildLivenessProbe/BuildReadinessProbefor probe configurationNormalizeReplicasfor default replica handlingAddImagePullSecretsfor image pull secret configurationreconcileServiceComponenthelper to controllerChanges
Test plan
go build ./...passesgo test ./pkg/... -vpasses