Repository navigation
Recover fleet arrival alerts when polling misses warp history - #293
Closed
Guffawaffle wants to merge 2 commits into
Closed
Guffawaffle wants to merge 2 commits into
Guffawaffle wants to merge 2 commits into
Conversation
Owner
Author
|
Superseded by the combined Mac candidate #294: its fleet-arrival tracker and regression fixture contain these same two corrections. The fixes have also been carried to STFC-Mod#268. Closing the duplicate play promotion path while retaining its branch/history and evidence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fleet arrival detection could miss Warping -> Impulsing when polling observed an intermediate state or skipped Warping. Captured recall and outbound traces both retain native PreviousState=Warping at Impulsing.
Recover those arrivals using native history, requiring an observed journey and emitting once per journey. Baseline resets and fleet replacement discard saved history. The fallback is independent of view and intermediate state. Other notification rules are unchanged.
Regression cases replay both captured sequences, repeated arrival samples, normal travel, startup, reseeding and fleet replacement. Standalone source Windows build and pure tests pass. Fork Windows release build and all three review lanes passed at 19d405a. Deployed for Windows gameplay smoke; platform CI is running. This is a test candidate, not a play promotion.