Repository navigation
testing: focused macOS fleet audio baseline - #289
Closed
Guffawaffle wants to merge 37 commits into
Closed
Guffawaffle wants to merge 37 commits into
Guffawaffle wants to merge 37 commits into
Conversation
Use one descriptor catalog for parsing, dependency checks, and toast-state lookup while preserving unconditional config normalization.
# Conflicts: # mods/src/config.cc
…o-alerts' into feature/audio-disable-all # Conflicts: # mods/src/config.cc
… dailies (#284) Ex-borg dailies also award faction points, so their non-empty faction name (e.g. BorgTertius) made the bulk-claim filter drop them even though daily_bulk_claim_factions only controls the three main faction dailies. Restrict removal to dailies matching a main faction icon name and keep everything else unconditionally.
… the swiftUI plugin paths correctly
…macos-fleet-audio
…macos-fleet-audio
(cherry picked from commit d5c8a01)
(cherry picked from commit 49d8bc7)
(cherry picked from commit 5d67a8b) (cherry picked from commit ae7e64bce466d182d7e4193f699ee95ece37bfea)
…macos-fleet-audio
Owner
Author
|
Closing the completed test-baseline PR. The Mac audio investigation progressed into the arrival corrections and the combined Mac candidate #294, with current source work carried into STFC-Mod#253 and STFC-Mod#268. This test-only aggregate is not intended to merge into upstream-mirror main. Branch and published test artifacts are preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a focused macOS test baseline for intermittent fleet-arrival audio. Combines current upstream main 1.1.8.0 (
4bf238c1, including Fleet Watch) with notification audio #253, theAllnamed-event filter #259, fleet-transition consumer #268, and the previously isolated independent fleet-audio component.The branch preserves existing arrival detection so a reproducible correction can be stacked separately. It excludes unrelated personal play features. Notification integration retains macOS playback, idempotent service initialization, and Windows duplicate-toast suppression. All cues remain opt-in with
nonedefaults.Pinned inputs: #253
7933965b, #259cfe2227a, #268 consumerd5c8a010/49d8bc75, fleet audioae7e64bc. The shared observer is unchanged from upstream. Test instructions cover same-config reproduction and an isolated generated-arrival test.Includes upstream #291 (
bfa22bbd): explicit SwiftUI macro plugin paths for newer Xcode, XMake 3.1.1, sccache 0.18.0, and macOS deployment target 14.6. The inconsistent 14.5 instruction and launcher LSMinimumSystemVersion metadata are aligned to 14.6. This build requires macOS 14.6 or newer.Validation: previous audio baseline passed all platform builds, local Windows build, example TOML validation, three review lanes and universal archive verification. Fleet/audio implementation is unchanged by #291. Updated workflow actionlint and diff check pass; all three correction-delta review lanes pass at
1b3b48e5. Updated CI passed Windows, ARM64, Intel, and Mac packaging. Downloaded universal archive checksum verified; installer and standalone dylib match, and both slices of launcher/loader/mod plus the packaged plist require macOS 14.6. CI merge 1ef188c has the same source tree as reviewed head 1b3b48e. Earlier run 35329802787/artifacts predate #291 and are superseded for this test. Exact-client macOS hook/runtime and intermittent arrival remain to be validated.Test-only draft; not an aggregate merge request for the upstream-mirror main branch.
Downloads: Mac installer | Universal dylib.
Universal archive SHA256: 2a26be1853519b0735e9d233bff9f066c80963d28f7323f08d3edb52787cbd3a. Dylib SHA256: d97d63e62ebd138c5c5c5f48a3274eda1e91c7bbb29741457340835fe58a4526.