fix: drop empty trailing div from context menu blade#152
Open
davidnaviaweb wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The trailing
<div>inresources/views/components/context-menu.blade.phpcontains only commented-out Blade markup (lines 37-58 — old per-context dropdown lists, now superseded by the<template x-for="action in actions">loop). At render time the comments are stripped and the wrapper renders as an empty<div>.The parent panel uses Tailwind's
divide-y, which translates to aborder-topon every direct child after the first. The empty trailing<div>therefore picks up a divider that paints just below the dropdown list, outside the rounded panel — visible as a stray horizontal line below the menu.Fix
Remove the empty
<div>block. The<template x-for="action in actions">loop already covers every context (DateClick, DateSelect, EventClick, NoEventsClick) since the actions collection is filtered per-context byHasContextMenu::getContextMenuActionsUsing()upstream of the view.Verification
Tested on Filament v4 + Tailwind v4. The dropdown panel now ends cleanly at the last action item; no functional regression in the four context scenarios.