fix[next]: raise on disjoint inverse image#2616
Open
havogt wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the embedded NdArrayConnectivityField.inverse_image() path where a disjoint inverse image (no indices mapping into the requested image range) could previously crash inside _hyperslice(); it now cleanly triggers the existing ValueError for non-contiguous/invalid restrictions. A regression test is added to ensure this behavior is enforced.
Changes:
- Make
_hyperslice()returnNonewhen the selected mask is empty (disjoint inverse image), avoidingmin/maxon empty indices. - Add a unit test asserting
premap()raisesValueErrorfor a disjoint inverse image.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/gt4py/next/embedded/nd_array_field.py |
Prevents _hyperslice() from crashing on empty selections so disjoint inverse images raise the intended ValueError. |
tests/next_tests/unit_tests/embedded_tests/test_nd_array_field.py |
Adds regression coverage for premap() when the connectivity’s inverse image is disjoint from the field domain. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small bug discovered by claude on the side