Skip to content

Lots of changes (see changelog), most notably the refactoring of the NR algorithms and lots of renaming - #137

Open
BDonnot wants to merge 93 commits into
dev_0.13.2from
refacto_NR
Open

Lots of changes (see changelog), most notably the refactoring of the NR algorithms and lots of renaming#137
BDonnot wants to merge 93 commits into
dev_0.13.2from
refacto_NR

Conversation

@BDonnot

@BDonnot BDonnot commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

BDonnot added 30 commits April 21, 2026 11:55
@BDonnot
add a custom solver registry allowing to use solver defined in other …
9a95137 
…libraries

Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
fix test on windows + add tests for the external solver feature in CI
1e27fd2 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
start dev 0.13.2
315757f 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
put everything under c++ namespace ls2g
d80d0e6 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
refacto solver [skip ci]
51e4d00 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
auto register solvers at library time
1dd8c8a 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
refacto for splitting core cpp library and python binding done [skip ci]
8af12a6 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
refacto to make it cleaner between ls2g core and python binding [skip…
527b7f9 
… ci]

Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
refacto the lightsim2grid sources
a63c62b 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
fix some compilation bug on CI + add verbose flags
766af3d 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
add tests in CI to check different KLU integration
57c6fa6 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
add scikit build core in requirement_ci
92f23ca 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
try to fix KLU in github CI
7763885 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
use to_numpy instead of .values in pandapower converter [skip ci]
ad54797 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
fix CI issues on github
bc05a7c 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
synch with dev_0.13.2
7a781b7 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
still fixing github CI
5589983 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
fix compilation issue on windows in CI
d57aa7d 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
still fixing windows build, search path for DLL was broken
de4e30c 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
fixing a root directory on windows still
73bf775 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
forget to add a test file in git
6522066 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
some code quality improvments
5877fe0 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
start to refactor NR algorithm to allow for other types of solvers in…
4d565dc 
… the future

Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
attempt to fix issue in NR algo refacto
78e82ea 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
fix some broken tests after first refacto
236dd3a 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
refactor NR solver : integration of slack policy
a60ec3f 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
start to add a scaling policy, not satisfied with the current design …
2415c16 
…[skip ci]

Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
refactor the algo with new methods
0bdce04 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
simplify the scaling policies layout from the NRAlgo
948daa9 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
clarify the refactor policy once again
b488b7b 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
BDonnot and others added 28 commits June 8, 2026 22:29
@BDonnot
forget to add the docs requirement in the pyproject.toml
9881b5d 
Signed-off-by: Benjamin DONNOT <benjamin.donnot@gmail.com>
@BDonnot
fix workflow whl count after removing python 3.8
0e39485 
Signed-off-by: Benjamin DONNOT <benjamin.donnot@gmail.com>
@BDonnot
improve timings for different part of linear solver solve, split line…
d1deadc 
…ar solver API between initialize, now initialize and factorize

Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
add a structure for the timings
b0ff813 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
improve computation speed of DC and find a way to output timings when…
a7c620a 
… running the benchmarks

Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
improve computation speed of dc
1f9d339 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
refacto again the jacobian to make further improvements easier
4d63393 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
start to add proper HVDC in lightsim2grid [skip ci]
958de25 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
improve dc computation
5efed28 
Signed-off-by: Benjamin DONNOT <benjamin.donnot@gmail.com>
@BDonnot
finalize the HVDC implementation
5557fad 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot @claude
Phase 0: pin OLF voltage-control conventions via probes
e7acaca 
Documented probe scripts that pin, against PowSyBl OpenLoadFlow, the
conventions the bordered VoltageControl extension must match:
- SVC slope sign/units: Vm(reg) = vset - s_pu*Q (generator injection),
  s_pu = slope_kV/MVar * sn_mva / vn_kv(reg bus)
- N>1 reactive sharing: Q_EQUAL_PROPORTION, w_i = qmax_i - qmin_i
- degenerate configs that v1 rejects rather than reclassifying buses

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot @claude
Phase 1: bordered VoltageControl NRSystem extension
8d13834 
Add the composable VoltageControl extension that implements remote voltage
control and SVCs with a single bordered formulation: per control group it
claims N reactive-injection columns, one voltage-constraint row and N-1
reactive-sharing rows in the NRLedger, leaving every bus an ordinary PQ bus
(no reclassification, no PQV type, no Q-limit outer loop). Jacobian feature
entries are declared unconditionally so the KLU symbolic factorization is
reused. With zero control groups the ledger / J sparsity / results are
bit-identical to before.

- VoltageControlData.hpp: flat solver-side struct (controllers + groups)
- NRSystem.hpp: VoltageControl extension + controller_q/kind/elem_id
  accessors; aliases become NRSystem<Base[,MultiSlack],VoltageControl,Hvdc>
- NRSystemVoltageControl.cpp: out-of-line update_state
- BaseAlgo/NRAlgo/AlgorithmSelector: get_controller_q/kind/elem_id plumbing

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot @claude
Phase 2: grid-model plumbing for remote gens + SVC
03d3a0f 
Thread remote voltage control and the new SVC element through the grid model
and into the VoltageControl extension.

- GeneratorContainer: regulated_bus_id_ (remote control), fillpv/set_vm/
  get_vm_for_dc/init_q_vector adjusted, StateRes regulated-bus slot
- SvcContainer (new): VOLTAGE (local/remote, optional slope), REACTIVE_POWER,
  OFF; b_min/b_max stored but never enforced
- LSGrid: svcs_ member + wiring (fillSbus/compute_results/reset_results/
  set_vm/state), fill_voltage_control_solver_data with v1 validation
  (controller on PV/slack, conflicting v_set, SVC sharing a bus), AC result
  write-back, SVC-aware check_solution
- fix: guard el_id range in GeneratorContainer/SvcContainer::_change_bus, which
  the caller runs before _generic_change_bus validates the id; the previously
  added regulated_bus_id_ write was an out-of-bounds write (heap corruption)
  for out-of-range element ids
- integration tests for remote gen + SVC (case14 through LSGrid)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot @claude
Phase 3: bindings + pypowsybl importer for voltage control
2497762 
- pybind11: SvcContainer/SvcInfo/get_svcs/init_svcs, SVC topology API +
  pickle, GenInfo.regulated_bus_id, set_gen_regulated_bus
- from_pypowsybl: thread the generator regulated bus and import SVCs
  (regulation mode, target_v->pu at the regulated bus, slope kV/MVar->pu,
  target_q negated to the generator-injection convention). Remote targets are
  resolved generically (busbar section, load, generator, ...) to their
  terminal bus, matching OpenLoadFlow. A grid with no remote control and no
  SVC stays byte-identical.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot @claude
Phase 4: OpenLoadFlow parity matrix for voltage control
493c572 
12 reference tests validating remote generator voltage control + SVC against
PowSyBl OpenLoadFlow through the pypowsybl converter to 1e-6: remote gen
(single + N>1 reactive sharing), SVC local/remote voltage, slope,
REACTIVE_POWER, OFF, v1 rejections, backward-compat and DC. OLF's slack is
pinned by NAME to the lightsim2grid slack so the angle reference matches.
Remote-SVC-with-slope is underspecified in OLF (it holds the regulated bus at
exactly vset), so that case checks our own Vm(reg)=vset-s*Q law instead.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
improving code for DC refactor
0d3e103 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
attempt to improve algo controler for trafo sbus
0d4e066 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
fix the optimization of Sbus only modified for trafo in DC
5ecde95 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
some remaining fixes for DC improvments
738d4f6 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
Merge pull request #138 from Grid2op/algo_control_improvent
58e249e 
improve dc computation

Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
synch with refacto_NR
cf065f0 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
fix merge issue, now it compiles
0c682f3 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
fix broken tests due to jacobian order changed
6332102 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
properly handle storage units from pypowsybl grid now
7de594e 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
improving the doc with the new changes
cd50f66 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
fix the way numpy<2 is installed in CI
16a8fd5 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
add todos for the remote control
1743bcc 
Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@BDonnot
Merge pull request #139 from Grid2op/refactoNR_2
366287e 
Refacto nr 2

Signed-off-by: DONNOT Benjamin <benjamin.donnot@rte-france.com>
@sonarqubecloud

sonarqubecloud Bot commented Jun 25, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
589 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BDonnot