Skip to content

Add a bunch of missing npc combat stats - #1360

Merged
GregHib merged 7 commits into
mainfrom
npc-stats
Oct 2, 2026
Merged

GregHib merged 7 commits into
mainfrom
npc-stats

Conversation

@GregHib

@GregHib GregHib commented Oct 2, 2026

Copy link
Copy Markdown
Owner

And add estimates for dungeoneering npc stats

Cross referenced current npc stats with osrs stats and an approximate 751 eoc to rs2 conversion algorithm (round(100 × 1.05^(L−10)) where L is 1-10 and npc dependent).

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.83%. Comparing base (2b8e267) to head (8cc0697).

Files with missing lines Patch % Lines
...gs/voidps/engine/data/definition/NPCDefinitions.kt 0.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...gs/voidps/engine/data/definition/NPCDefinitions.kt 68.10% <0.00%> (+1.13%) ⬆️

... and 2 files with indirect coverage changes

@@            Coverage Diff            @@
##               main    #1360   +/-   ##
=========================================
  Coverage     44.83%   44.83%           
- Complexity    12004    12005    +1     
=========================================
  Files          2230     2230           
  Lines        103598   103602    +4     
  Branches      16782    16786    +4     
=========================================
+ Hits          46453    46455    +2     
  Misses        50552    50552           
- Partials       6593     6595    +2     
Components Coverage Δ
Content 45.84% <ø> (-0.01%) ⬇️
Engine 46.68% <0.00%> (+0.01%) ⬆️
Network 72.33% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib
GregHib marked this pull request as ready for review October 2, 2026 23:11
@GregHib
GregHib merged commit f3455a5 into main Oct 2, 2026
5 checks passed
@GregHib
GregHib deleted the npc-stats branch October 2, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant