Skip to content

Add player owned houses and basics of construction - #1359

Merged
GregHib merged 28 commits into
mainfrom
construction
Oct 3, 2026
Merged

GregHib merged 28 commits into
mainfrom
construction

Conversation

@GregHib

@GregHib GregHib commented Oct 2, 2026 •

Copy link
Copy Markdown
Owner
  • Add player owned houses: instances, visiting, settings
  • Add furniture building
  • Add dungeons/first floor building
  • Add sitting on chairs
  • Add lit alter bonuses and bone usage
  • Add teleport focus and portals
  • Add teleport to house spell and tablet
  • Fix decoding single level maps
  • Fix clearing dynamic zones

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Qodana for JVM

21 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 18
Unused import directive 🔶 Warning 1
Redundant 'suspend' modifier 🔶 Warning 1
Cascade 'if' can be replaced with 'when' ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.49471% with 265 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.14%. Comparing base (2b8e267) to head (72bd5c0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...n/kotlin/content/skill/construction/HouseStairs.kt 59.21% 10 Missing and 21 partials ⚠️
...rc/main/kotlin/content/skill/construction/House.kt 87.55% 6 Missing and 24 partials ⚠️
.../kotlin/content/skill/construction/RoomCreation.kt 73.91% 11 Missing and 19 partials ⚠️
...in/content/skill/construction/FurnitureCreation.kt 74.56% 9 Missing and 20 partials ⚠️
...kotlin/content/skill/construction/PortalChamber.kt 46.66% 11 Missing and 13 partials ⚠️
...otlin/content/area/asgarnia/falador/EstateAgent.kt 73.13% 13 Missing and 5 partials ⚠️
.../kotlin/content/skill/construction/HouseOptions.kt 61.11% 8 Missing and 6 partials ⚠️
...otlin/content/skill/construction/HouseFurniture.kt 78.68% 4 Missing and 9 partials ⚠️
...n/kotlin/content/skill/construction/HousePortal.kt 84.14% 7 Missing and 6 partials ⚠️
...in/kotlin/content/skill/construction/HouseSeats.kt 77.19% 5 Missing and 8 partials ⚠️
... and 17 more
Additional details and impacted files
Files with missing lines Coverage Δ
...world/gregs/voidps/engine/map/zone/DynamicZones.kt 75.00% <100.00%> (ø)
game/src/main/kotlin/GameTick.kt 87.75% <100.00%> (ø)
...n/kotlin/content/skill/construction/HouseChapel.kt 100.00% <100.00%> (ø)
...e/src/main/kotlin/content/skill/cooking/Filling.kt 70.00% <100.00%> (ø)
...orld/gregs/voidps/engine/entity/obj/GameObjects.kt 67.78% <83.33%> (+1.61%) ⬆️
...gs/voidps/engine/map/collision/CollisionDecoder.kt 49.41% <83.33%> (+6.55%) ⬆️
...tlin/content/skill/construction/HouseDiningRoom.kt 75.00% <75.00%> (ø)
...n/kotlin/content/skill/prayer/bone/BoneOffering.kt 76.00% <75.00%> (+1.00%) ⬆️
...orld/gregs/voidps/engine/map/instance/Instances.kt 80.51% <84.61%> (+1.35%) ⬆️
.../kotlin/content/skill/construction/HouseBedroom.kt 66.66% <66.66%> (ø)
... and 21 more

... and 6 files with indirect coverage changes

@@             Coverage Diff              @@
##               main    #1359      +/-   ##
============================================
+ Coverage     44.83%   45.14%   +0.30%     
- Complexity    12004    12151     +147     
============================================
  Files          2230     2251      +21     
  Lines        103598   104607    +1009     
  Branches      16782    17063     +281     
============================================
+ Hits          46453    47223     +770     
- Misses        50552    50657     +105     
- Partials       6593     6727     +134     
Components Coverage Δ
Content 46.21% <74.70%> (+0.37%) ⬆️
Engine 46.76% <69.23%> (+0.10%) ⬆️
Network 72.37% <ø> (+0.03%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib
GregHib marked this pull request as ready for review October 3, 2026 09:56
@GregHib
GregHib merged commit 96b9ec0 into main Oct 3, 2026
5 checks passed
@GregHib
GregHib deleted the construction branch October 3, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant