Add object examines for a lot of the "most placed" objects - #1290
trunksbomb wants to merge 4 commits into
Conversation
…aced" objects (those with 75 or more placements). The reference is a Rune Server thread which is linked in `all_scraped.objs.toml`, where a user scraped examines from live RS2 servers in 2021. This commit adds examine texts for 135 unique objects, representing a total of 40,360 object placements in-world, as well as updating a few other commonly-placed objects that already had definitions in a `objs.toml` file but no examine text.
|
This is a wonderful addition. I am pleased. 😃 The rest is up to Greg to see if the implementation is how its should be implemented. |
GregHib
left a comment
There was a problem hiding this comment.
Thanks, we don't usually accept large amounts of definitions (we could ofc dump them all but then it becomes a mountain of unverified data and a huge manual undertaking to validate, so we favour adding them alongside content as we go), however what you've done with the most commonly used, and it's not necessarily objects which fit alongside content, it makes a lot of sense and I'm happy to merge this in once it's ready.
To get it ready it'd need some name changes and organisation,
Specifically removing the scraped_, you can check the official jagex names here, however they are not always great or consistent so best to use them as a guide.
As for organising just moving them to vaguely correct area based .obj.toml files, e.g. magical wheat is probably specific to just Zanaris, mineral veins from living rock caverns etc... rather than one big dump.obj.toml
| [wheat_zanaris] | ||
| clone = "wheat" | ||
| id = 15506 | ||
| examine = "Baby bread." |
There was a problem hiding this comment.
These aren't necessary, the examines will come from the cloned object
…examines from the parent object.
…rs and using proper names from the game files instead of dumping them all in a single file prepended with `scraped_`.
Add manually cross-referenced examine texts for a lot of the "most placed" objects (those with 75 or more placements). The reference is a Rune Server thread which is linked in
all_scraped.objs.toml, where a user scraped examines from live RS2 servers in 2021. This commit adds examine texts for 135 unique objects, representing a total of 40,360 object placements in-world, as well as updating a few other commonly-placed objects that already had definitions in aobjs.tomlfile but no examine text.Honestly it's mostly trees and wheat, but hey now they have descriptions.