Skip to content

Add object examines for a lot of the "most placed" objects - #1290

Open
trunksbomb wants to merge 4 commits into
GregHib:mainfrom
trunksbomb:main
Open

trunksbomb wants to merge 4 commits into
GregHib:mainfrom
trunksbomb:main

Conversation

@trunksbomb

Copy link
Copy Markdown
Contributor

Add manually cross-referenced examine texts for a lot of the "most placed" objects (those with 75 or more placements). The reference is a Rune Server thread which is linked in all_scraped.objs.toml, where a user scraped examines from live RS2 servers in 2021. This commit adds examine texts for 135 unique objects, representing a total of 40,360 object placements in-world, as well as updating a few other commonly-placed objects that already had definitions in a objs.toml file but no examine text.

Honestly it's mostly trees and wheat, but hey now they have descriptions.

…aced" objects (those with 75 or more placements). The reference is a Rune Server thread which is linked in `all_scraped.objs.toml`, where a user scraped examines from live RS2 servers in 2021. This commit adds examine texts for 135 unique objects, representing a total of 40,360 object placements in-world, as well as updating a few other commonly-placed objects that already had definitions in a `objs.toml` file but no examine text.
@skalfate

Copy link
Copy Markdown
Contributor

This is a wonderful addition. I am pleased. 😃 The rest is up to Greg to see if the implementation is how its should be implemented.

@GregHib GregHib left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we don't usually accept large amounts of definitions (we could ofc dump them all but then it becomes a mountain of unverified data and a huge manual undertaking to validate, so we favour adding them alongside content as we go), however what you've done with the most commonly used, and it's not necessarily objects which fit alongside content, it makes a lot of sense and I'm happy to merge this in once it's ready.

To get it ready it'd need some name changes and organisation,
Specifically removing the scraped_, you can check the official jagex names here, however they are not always great or consistent so best to use them as a guide.
As for organising just moving them to vaguely correct area based .obj.toml files, e.g. magical wheat is probably specific to just Zanaris, mineral veins from living rock caverns etc... rather than one big dump.obj.toml

Comment thread data/entity/obj/all.objs.toml Outdated
[wheat_zanaris]
clone = "wheat"
id = 15506
examine = "Baby bread."

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't necessary, the examines will come from the cloned object

…rs and using proper names from the game files instead of dumping them all in a single file prepended with `scraped_`.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants