Using test environment for Mantine provider in preflight tests. - #27415
Open
dennisoelkers wants to merge 1 commit into
Open
dennisoelkers wants to merge 1 commit into
dennisoelkers wants to merge 1 commit into
Conversation
jsdom performs no layout, so every `getBoundingClientRect()` is 0x0 and `documentElement.clientWidth/clientHeight` are 0. Floating UI's `hide()` middleware - which Mantine always installs - therefore reports the menu target as fully clipped, and Mantine renders the dropdown with `display: none`, taking its items out of the accessibility tree. Mantine guards that behaviour behind `env !== 'test'`. The main test wrapper already passes `env="test"` via `DefaultProviders`, but the preflight wrapper reuses the production theme providers, so its innermost `MantineProvider` ran with the default env. The test only passed when the assertion happened to observe the dropdown before the asynchronous position update landed, which is why it failed under load on CI. Thread the same `env` prop through `ThemeWrapper` and set it from `PreflightWrappingContainer`, and cover the previously racy case with a test that asserts the links after the position update has settled. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR is a minor fix for preflight frontend tests. It explicitly sets the
testenvironment for the Mantine theme provider, so specific production-only functionality which does not work in JSDom is disabled. This is similar to what we do already in non-preflight tests./nocl Internal refactoring.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: