Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
One or more issues must be addressed before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Extracts a reusable plugin-backed tactics/techniques detail row and integrates it into event details.
Changes:
- Adds plugin lookup and feature gating.
- Adds unit tests for plugin states.
- Replaces the local implementation in
ExpandedSection.
File summaries
| File | Description |
|---|---|
| graylog2-web-interface/src/components/events/TacticsTechniquesDetailRow.tsx | Updated as part of this pull request. |
| graylog2-web-interface/src/components/events/TacticsTechniquesDetailRow.test.tsx | Updated as part of this pull request. |
| graylog2-web-interface/src/components/events/ExpandedSection.tsx | Updated as part of this pull request. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ) : null} | ||
| <TagsDetailRow tags={event.tags} /> | ||
| <TacticsTechniquesPluginRow event={event} /> | ||
| <TacticsTechniquesDetailRow entity={event} /> |
| ) : null} | ||
| <TagsDetailRow tags={event.tags} /> | ||
| <TacticsTechniquesPluginRow event={event} /> | ||
| <TacticsTechniquesDetailRow entity={event} /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracts a shared
TacticsTechniquesDetailRowcomponent that looks up the Security app's tactics/techniques row viausePluginEntities('events.components.tacticsTechniquesDetailRow')and renders it when a plugin registers it.ExpandedSectionnow renders this shared component instead of leaving the tactics/techniques field unhandled./nocl
Motivation and Context
Tactics/Techniques defined on an event definition were not shown in the right-hand sidebar (Replay Search) or in the Events Overview Widget's event details modal, because there was no shared place for a plugin to contribute this row to
ExpandedSection.This PR provides the shared component;
graylog-plugin-enterpriseregisters the actual row implementation against it (see linked PR below).Closes: Graylog2/graylog-plugin-enterprise#14364
/prd https://github.com/Graylog2/graylog-plugin-enterprise/pull/15647
How Has This Been Tested?
Added unit tests for
TacticsTechniquesDetailRowcovering the plugin-present/absent and enabled/disabled cases.Screenshots (if appropriate):
Types of changes
Checklist: