Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified in the reviewed changes.
Pull request overview
Fixes Event Definition type labeling and adds system-notifications-v1 to the frontend type filter.
Changes:
- Renames the type label to “Event Definition Type”.
- Registers system notifications as a filter-only type.
- Makes components optional for non-editable types.
- Adds tests and a changelog entry.
File summaries
| File | Summary |
|---|---|
graylog2-web-interface/src/components/event-definitions/types.ts |
Allows component-less event definition types. |
graylog2-web-interface/src/components/event-definitions/event-definition-types/bindings.ts |
Registers the system event definition type. |
graylog2-web-interface/src/components/event-definitions/event-definition-types/bindings.test.ts |
Tests the new registry entry. |
graylog2-server/src/main/java/org/graylog/events/rest/EventDefinitionsResource.java |
Updates the type attribute label. |
changelog/unreleased/issue-14755.toml |
Documents the fix. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
danotorrey
approved these changes
Sep 16, 2026
danotorrey
left a comment
Contributor
There was a problem hiding this comment.
LGTM and tests successfully. Just one CL change needed to add pull request number.
| @@ -0,0 +1,4 @@ | |||
| type = "fixed" | |||
| message = "Rename the Event Definitions type filter to \"Event Definition Type\" and include the System Event Definition type as a filter option." | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Add PR number to CL.
Suggested change
| pulls = ["27397"] |
kingzacko1
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
EventDefinitionsResource.java, so it no longer shares wording with the unrelated Alert/Event type filter on the Alerts & Events page.eventDefinitionTypesplugin-registry entry forsystem-notifications-v1(bindings.ts), so the System Event Definition type now appears as a filter option. It follows the samehideFromCreationpattern used forsigma-v1/sigma-correlation-v1(visible as a filter, hidden from the create wizard, no form/summary component since it's never user-editable). MadeformComponent/summaryComponentoptional onEventDefinitionTypeintypes.tsto support that.sigma-correlation-v1was already showing up correctly (fixed by an unrelated commit merged after this issue was filed), so no changes were needed for that part.Motivation and Context
Closes: Graylog2/graylog-plugin-enterprise#14755
The Event Definitions type filter had inconsistent wording (same label as the unrelated Alerts & Events type filter) and was missing the
system-notifications-v1type.How Has This Been Tested?
yarn tsgo,yarn lint:pathon changed filesyarn test --testPathPatterns=event-definitions(19 suites / 121 tests)yarn test --testPathPatterns=components/events(13 suites / 58 tests, coversColumnRenderers/EventDefinitionTypeRenderer)./mvnw test -pl :graylog2-server -Dtest=EventDefinitionsResourceTest -Dskip.web.build=true -Dmaven.javadoc.skip=true(10/10 tests)bindings.test.tscovering the new registry entry.Screenshots (if appropriate):
Types of changes
Checklist:
🤖 Generated with Claude Code