fix(14302): Fixed tags colors - #27390
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A moderate form-submission regression and missing style assertions remain.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Fixes incorrect colors for event sidebar tag chips.
Changes:
- Updates clickable tag rendering and interaction styles.
- Preserves chip truncation styling.
File summaries
| File | Summary |
|---|---|
graylog2-web-interface/src/components/common/ChipsCell.tsx |
Updates chip markup and styling. Moderate (3 votes): button behavior may submit a containing form. Nit (3 votes): add tests asserting chip styles. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
146
to
149
| onClick={(e: React.MouseEvent) => { | ||
| e.stopPropagation(); | ||
| onItemClick(item); | ||
| }} |
Comment on lines
+64
to
+65
| &:where(button):hover { | ||
| background-color: ${theme.colors.gray[60]}; |
kingzacko1
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the colors of tags shown in the event sidebar details, so they render correctly instead of using incorrect/inconsistent chip colors.
Motivation and Context
Tags displayed in the event sidebar details were not showing with the correct colors.
Closes: Graylog2/graylog-plugin-enterprise#14302
/prd Graylog2/graylog-plugin-enterprise#15582
/nocl
How Has This Been Tested?
Manually verified that tags in the event sidebar details render with the correct chip colors.
Screenshots (if appropriate):
Types of changes
Checklist: