Let resolvers restrict what a grant confers on expanded targets - #27381
Open
dennisoelkers wants to merge 3 commits into
Open
dennisoelkers wants to merge 3 commits into
dennisoelkers wants to merge 3 commits into
Conversation
DefaultPermissionAndRoleResolver#resolveTargets lets subclasses expand a grant target into several targets. The enterprise resolver uses this to expand a collection into its entities and a team's users into the member users themselves. Until now the grant's capability was applied unchanged to every expanded target, so a capability on a container silently became the same capability on each of its members. Extracts the capability lookup into an overridable permissionsFor(grant, target), plus a permissionsFor(capability, target) helper subclasses can delegate to when they need to narrow the capability for a target. No behaviour change on its own. It is the hook used by the enterprise fix for team membership conferring users:edit and users:rolesedit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
DefaultPermissionAndRoleResolver#resolveTargetslets subclasses expand a grant target into several targets. The enterprise resolver uses this to expand a collection into its entities and a team's users into the member users themselves. Until now the grant's capability was applied unchanged to every expanded target, so a capability on a container silently became the same capability on each of its members.Extracts the capability lookup into an overridable
permissionsFor(grant, target), plus apermissionsFor(capability, target)helper subclasses can delegate to when they need to narrow the capability for a target./prd Graylog2/graylog-plugin-enterprise#15607
/nocl No user-facing change.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: