Add config option to enforce allowlist for Slack/Teams notifications - #26814
Add config option to enforce allowlist for Slack/Teams notifications#26814ryan-carroll-graylog wants to merge 9 commits into
Conversation
|
@boosty please let me know if this all looks ok to you. I went with a System config option since it seemed like something an admin would want to flip on to enforce across the board, and the individual notification configs already warn if an individual URL is not whitelisted as of the previous PR (although not prevented from creating the config anyway) If you had something else in mind I'm happy to tweak it. |
boosty
left a comment
There was a problem hiding this comment.
Thanks for working on this!
Left a few comments.
I am missing a test for the new behaviour of graylog2-server/src/main/java/org/graylog2/system/urlallowlist/UrlAllowlist.java.
|
Thanks @boosty , yeah I think the comment was out of place and confusing. My intent is to capture that we've added this global looking opt in/out config field, but it's really just affecting the Slack/Teams notifications right now, and that it should go away at the next major release when we just enforce URL allowlist across the board. I moved the relevant bits to the new Please lmk if that makes sense to you. |
|
Thanks @ryan-carroll-graylog. In general I am happy about making this a config option. I would leave the rest of the code review and testing to your team. But my comment above remains: The change in |
Apologies I missed the test on my commit, just added. Thanks for taking a look @boosty ! |

Description
System > Configuration > URL Allowlistdefaulting to disabledAfter Graylog is upgraded, if there are Slack or Teams Notifications using webhook URLs that are not in the allowlist, a warning will be logged directing users to optionally add Slack/Teams Notifications to URL Allowlist enforcement:
Motivation and Context
Follow on to #26619
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: