fix(streams): streams overview page field fixes - #26811
Open
laura-b-g wants to merge 7 commits into
Open
Conversation
Both descriptors previously defaulted to 0.0 for streams absent from the OpenSearch aggregation (no messages in the last 15 min). A null return lets the frontend distinguish no-data from a genuine computed 0 ms.
The Running/Paused colored pill caused visual noise in the table: varying widths, heavy fills, and positional jitter from centering. Replace with a small colored dot + the status word, left-aligned. The click-to-toggle action stays in the cell with a hover state and toggle icon to signal interactivity. Non-editable rows show the dot and word only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes several display issues in the Streams overview. The Avg/Max Processing Time columns no longer show a misleading
0 msfor idle streams — the backend now returnsnullfor streams absent from the aggregation, and the frontend guard was tightened totypeof !== 'number'so only real numeric values (including a genuine0) are shown. The Status column pill is replaced with a quieter dot-and-tint indicator to reduce visual noise in the table. See Graylog2/graylog-plugin-enterprise#14639.Closes Graylog2/graylog-plugin-enterprise#14639
/prd Graylog2/graylog-plugin-enterprise#15016
Motivation and Context
StreamAvgProcessingTimeDescriptorandStreamMaxProcessingTimeDescriptorusedresults.getOrDefault(id, 0.0), conflating "stream absent from the aggregation result" with "stream processed all messages in ~0ms". The frontend guard used a falsy check (!value), which also treated a real0as missing. The Running/Paused status pill used a full-color fill, causing varying widths and visual noise across rows.How can this be tested?
Setup: a Graylog instance with both active streams (receiving messages) and idle streams (no recent traffic). The companion enterprise PR (
/prd) must also be applied.Happy path:
Edge case:
0 ms, not blankScreenshots (if appropriate)
Types of changes
Checklist
/nocl