Add AWSAuthFactory.createCloseable to release the assume-role STS client - #26808
Open
patrickmann wants to merge 1 commit into
Open
Add AWSAuthFactory.createCloseable to release the assume-role STS client#26808patrickmann wants to merge 1 commit into
patrickmann wants to merge 1 commit into
Conversation
buildStsCredentialsProvider hands a fresh StsClient to StsAssumeRoleCredentialsProvider, which never closes it: StsCredentialsProvider.close() only clears the session cache. A caller that builds a provider per operation therefore leaks the STS client's Apache connection pool on every call. Add createCloseable(...), returning a CredentialsProviderHandle that bundles the provider with its STS client so a caller can close both. The existing create(...) overloads delegate to it and discard the handle, so their behaviour is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/nocl
Description
AWSAuthFactory.buildStsCredentialsProvidercreates anStsClientand hands it toStsAssumeRoleCredentialsProvider, which never closes it:StsCredentialsProvider.close()only clears the session cache. A caller that builds a credentials provider per operation therefore leaks the STS client's Apache connection pool on every call.This adds
AWSAuthFactory.createCloseable(...), which returns aCredentialsProviderHandlebundling the provider with its STS client so a caller can close both. The existingcreate(...)overloads delegate to it and discard the handle, so their behaviour is unchanged.First consumer is the Data Lake backend validator fix in
Graylog2/graylog-plugin-enterprise#15011.How Tested
AWSAuthFactoryTest: two new cases (assume-role handle closes the STS client and provider; static-credentials handle has no STS client and closes safely).Types of changes
Checklist: