Skip to content

Switch the Color struct back to storing unassociated alpha - #4518

Merged
Keavon merged 3 commits into
masterfrom
straight-alpha-image-pixels
Sep 12, 2026
Merged

Switch the Color struct back to storing unassociated alpha#4518
Keavon merged 3 commits into
masterfrom
straight-alpha-image-pixels

Conversation

@TrueDoctor

@TrueDoctor TrueDoctor commented Sep 11, 2026

Copy link
Copy Markdown
Member

Fix translucent image colors by reverting the Color struct to store unmultiplied alpha and eliminating the faulty squared alpha.
image

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 11 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread node-graph/libraries/no-std-types/src/color/color_types.rs
Comment thread node-graph/libraries/no-std-types/src/color/color_types.rs
Comment thread node-graph/libraries/raster-types/src/image.rs
@TrueDoctor
TrueDoctor marked this pull request as draft September 11, 2026 17:39

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 13 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread editor/src/messages/portfolio/document_migration.rs
@Keavon Keavon changed the title Switch Color struct back to storing unassociated alpha Switch the Color struct back to storing unassociated alpha Sep 12, 2026
@Keavon
Keavon added this pull request to the merge queue Sep 12, 2026
Merged via the queue into master with commit 944d00c Sep 12, 2026
12 checks passed
@Keavon
Keavon deleted the straight-alpha-image-pixels branch September 12, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants