Skip to content

Use cargo workspace to remove duplicated version, license, and author fields #4226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timon-schelling wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use cargo workspace to remove duplicated version, license, and author fields #4226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 32 additions & 32 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions desktop/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[package]
name = "graphite-desktop"
version = "0.1.0"
description = "Graphite Desktop"
authors = ["Graphite Authors <contact@graphite.art>"]
license = "MIT OR Apache-2.0"
repository = ""
edition = "2024"
rust-version = "1.87"

@gemini-code-assist gemini-code-assist Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The rust-version constraint was removed during the workspace migration. Please add rust-version.workspace = true to ensure the package adheres to the workspace's Rust version constraint.

Suggested change
rust-version = "1.87"
rust-version.workspace = true

version.workspace = true
license.workspace = true
authors.workspace = true
edition.workspace = true
rust-version.workspace = true
publish.workspace = true
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.

@cubic-dev-ai cubic-dev-ai Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The description = "Graphite Desktop" field was removed without inheriting one from the workspace, so the crate now has no description. Workspace [workspace.package] does not define a description field, so this is a net loss. Other migrated crates here (editor, desktop/wrapper) never had descriptions, so they weren't affected.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At desktop/Cargo.toml, line 8:

<comment>The `description = "Graphite Desktop"` field was removed without inheriting one from the workspace, so the crate now has no description. Workspace `[workspace.package]` does not define a `description` field, so this is a net loss. Other migrated crates here (editor, desktop/wrapper) never had descriptions, so they weren't affected.</comment>

<file context>
@@ -1,12 +1,12 @@
+license.workspace = true
+authors.workspace = true
+edition.workspace = true
+publish.workspace = true
+# Inherited from workspace - end
 
</file context>

@TrueDoctor TrueDoctor Sep 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you double check if this is the case?

@cubic-dev-ai cubic-dev-ai Bot Sep 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TrueDoctor Good catch — that comment doesn't hold for the current state of the PR. The description = "Graphite Desktop" field is still present in desktop/Cargo.toml; it's an unchanged context line in the diff, not a removal. The actual removals are version, authors, license, repository, edition, and rust-version, which matches the +7 -6 count on that file.

So there's no lost description, and no need to add a description to [workspace.package] for this file. If my comment was based on an intermediate diff where it looked removed, the current file content supersedes that.

One adjacent thing worth noting while you're here: the migration also drops rust-version = "1.87" from these crates (and the workspace previously had 1.87/1.88 discrepancies across crates). If [workspace.package] doesn't define rust-version, those crates will fall back to the edition default. That's a separate concern from the description claim, but it's the same "was it actually inherited?" question, so worth a quick check against the root Cargo.toml.

Tip: get faster answers by chatting with cubic’s review copilot in the review UI


[[bin]]
name = "graphite"
Expand Down
12 changes: 6 additions & 6 deletions desktop/bundle/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[package]
name = "graphite-desktop-bundle"
version = "0.0.0"
description = "Graphite Desktop Bundle"
authors = ["Graphite Authors <contact@graphite.art>"]
license = "MIT OR Apache-2.0"
repository = ""
edition = "2024"
rust-version = "1.87"

@gemini-code-assist gemini-code-assist Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The rust-version constraint was removed during the workspace migration. Please add rust-version.workspace = true to ensure the package adheres to the workspace's Rust version constraint.

Suggested change
rust-version = "1.87"
rust-version.workspace = true

version.workspace = true
license.workspace = true
authors.workspace = true
edition.workspace = true
rust-version.workspace = true
publish.workspace = true

[dependencies]
cef-dll-sys = { workspace = true }
Expand Down
12 changes: 6 additions & 6 deletions desktop/embedded-resources/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[package]
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
name = "graphite-desktop-embedded-resources"
version = "0.1.0"
description = "Graphite Desktop Embedded Resources"
authors = ["Graphite Authors <contact@graphite.art>"]
license = "MIT OR Apache-2.0"
repository = ""
edition = "2024"
rust-version = "1.87"

@gemini-code-assist gemini-code-assist Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The rust-version constraint was removed during the workspace migration. Please add rust-version.workspace = true to ensure the package adheres to the workspace's Rust version constraint.

Suggested change
rust-version = "1.87"
rust-version.workspace = true

version.workspace = true
license.workspace = true
authors.workspace = true
edition.workspace = true
rust-version.workspace = true
publish.workspace = true

[dependencies]
include_dir = { workspace = true }
Expand Down
12 changes: 6 additions & 6 deletions desktop/platform/linux/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[package]
name = "graphite-desktop-platform-linux"
version = "0.0.0"
description = "Graphite Desktop Platform Linux"
authors = ["Graphite Authors <contact@graphite.art>"]
license = "MIT OR Apache-2.0"
repository = ""
edition = "2024"
rust-version = "1.87"

@gemini-code-assist gemini-code-assist Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The rust-version constraint was removed during the workspace migration. Please add rust-version.workspace = true to ensure the package adheres to the workspace's Rust version constraint.

Suggested change
rust-version = "1.87"
rust-version.workspace = true

version.workspace = true
license.workspace = true
authors.workspace = true
edition.workspace = true
rust-version.workspace = true
publish.workspace = true

[[bin]]
name = "graphite"
Expand Down
12 changes: 6 additions & 6 deletions desktop/platform/mac/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[package]
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
name = "graphite-desktop-platform-mac"
version = "0.0.0"
description = "Graphite Desktop Platform Mac"
authors = ["Graphite Authors <contact@graphite.art>"]
license = "MIT OR Apache-2.0"
repository = ""
edition = "2024"
rust-version = "1.87"

@gemini-code-assist gemini-code-assist Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The rust-version constraint was removed during the workspace migration. Please add rust-version.workspace = true to ensure the package adheres to the workspace's Rust version constraint.

Suggested change
rust-version = "1.87"
rust-version.workspace = true

version.workspace = true
license.workspace = true
authors.workspace = true
edition.workspace = true
rust-version.workspace = true
publish.workspace = true

[features]
main = ["dep:graphite-desktop"]
Expand Down
Loading
Loading