Cleanup: organize docs + fix stale claims + scrub IGV debug/dead code - #89
Merged
Conversation
Structure: repo root now holds only README.md + CLAUDE.md. Moved stray operational docs into docs/ subdirs (deployment/, guides/, testing/, security/), consolidated the 3 overlapping Multipass VM docs into one docs/guides/vm-setup.md, grouped the OAuth docs under docs/security/, and deleted an obsolete one-time cleanup artifact. All inbound links + the docs index updated; no broken links. Accuracy: removed/relabeled stale infrastructure claims presented as current — the nonexistent iOS app (architecture-overview), Redis in the README installer list, and a "this is aspirational" note on detailed-overview's PostgreSQL/Prisma/ React Native/Redis sections. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Remove ~16 leftover [Graph Debug]/[CRITICAL DEBUG]/emoji console.log debug statements from app code (kept the genuine console.error error handlers). - Delete two commented-out dead blocks (a disabled refreshTextVisibility effect and a disabled visibilitychange handler) + a now-empty debug if. - Dedupe the 4 identical local hexToRgb() definitions into one module-level helper. Verified: typecheck + lint (0 errors) + build clean, smoke 5/5, node-inspector + node-expand-legibility diagnostics 3/3. No behavior change (the currentTransform .k reads were verified CORRECT — a local d3.zoomTransform shadows the state inside initializeVisualization — so they were left untouched). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-existing issues + sprawl cleanup (no behavior change). -718 net lines.
Docs — structure & accuracy
README.md+CLAUDE.md. Moved the stray operational docs intodocs/subdirs (deployment/,guides/,testing/,security/).docs/guides/vm-setup.md; grouped the OAuth docs underdocs/security/; deleted an obsolete one-time cleanup artifact.scripts/setup-oauth.sh, cross-doc links) + the docs index updated — no broken links (grep-verified).detailed-overview.md(PostgreSQL/Prisma/React Native/Redis were presented as current).Code — scrub
InteractiveGraphVisualization.tsx[Graph Debug]/emojiconsole.logdebug statements from app code (kept the genuineconsole.errorhandlers).if.hexToRgb()definitions into one module-level helper.Notable non-fix (verified false positive)
A prior review flagged
currentTransform?.kas "always undefined" — it's correct: insideinitializeVisualizationa locald3.zoomTransform(...)shadows the React state, so.kreads the realZoomTransform. Changing it would have created a bug. Left untouched.Deferred (one item)
The duplicated SVG glow-filter construction blocks (3–4 sites) — confirmed real duplication, but it's the one change automated tests can't fully verify (subtle glow animation/visual diffs). Better as a focused PR with screenshot QA than bundled into a broad cleanup.
Verified: typecheck + lint (0 errors) + build clean; smoke 5/5; node-inspector + node-expand-legibility diagnostics 3/3.
🤖 Generated with Claude Code