Conversation
…patibility JAX 0.10 removed jax.interpreters.batching.not_mapped (the 'not batched' sentinel in batching rules, now simply None). The `_make_batcher` function in primitives.py still referenced the removed attribute, raising AttributeError on JAX >= 0.10. Replace `batching.not_mapped` with `None` in the batching rule generator, matching the new JAX batching convention.
There was a problem hiding this comment.
Pull request overview
This PR updates NUFFT primitive batching rules to be compatible with JAX 0.10+, where the “not batched” sentinel jax.interpreters.batching.not_mapped was removed in favor of using None.
Changes:
- Replaces the removed
batching.not_mappedsentinel usage in_make_batcher. - Updates
vmapin_axesconstruction to align with the newNone-based convention.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| def batcher(args, dims, **kwargs): | ||
| batched = [i for i, d in enumerate(dims) if d is not batching.not_mapped] | ||
| batched = [i for i, d in enumerate(dims) if d is not None] |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JAX 0.10 removed
jax.interpreters.batching.not_mapped(the 'not batched' sentinel in batching rules, now simplyNone). The_make_batcherfunction inprimitives.pystill referenced the removed attribute, raisingAttributeErroron JAX >= 0.10.Replace
batching.not_mappedwithNonein the batching rule generator, matching the new JAX batching convention.