Skip to content

fix: include tied embeddings in selective downloads - #496

Closed
burak33bb wants to merge 1 commit into
GradientHQ:mainfrom
burak33bb:codex/fix-selective-download-tied-embeddings
Closed

burak33bb wants to merge 1 commit into
GradientHQ:mainfrom
burak33bb:codex/fix-selective-download-tied-embeddings

Conversation

@burak33bb

Copy link
Copy Markdown

Summary

  • include tie_word_embeddings from normalized config when selecting weight files to download for the final shard
  • add regression coverage for tied embeddings where embed_tokens must be downloaded for the last shard

Duplicate check

  • reviewed contribution guide and recent open/closed issues and PRs
  • searched for tie_word_embeddings selective download lm_head, selective download, and tied embeddings download; only the original selective-download feature PR appeared, with no duplicate fix

Tests

  • python -m black --check src/parallax/utils/model_download.py tests/test_model_download.py
  • python -m ruff check --select E,F src/parallax/utils/model_download.py tests/test_model_download.py
  • direct invocation of tests/test_model_download.py test functions passed with PYTHONPATH=src

Note: pytest tests/test_model_download.py could not collect on this Windows environment because repo tests/conftest.py imports mlx.core and MLX fails to load its DLL here. Full editable install also hit uvloop does not support Windows.

@burak33bb
burak33bb requested a review from a team September 1, 2026 14:49
@burak33bb burak33bb closed this Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants