add hide grades feature with --hide_grades flag - #155
Open
ericshermancs wants to merge 7 commits into
Open
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| number = input( | ||
| "Enter phone number: ") if not args.phone else args.phone | ||
| school = input( | ||
| "Enter college code: ").upper() if not args.school else args.school.upper() |
| refresh(remaining_attempts - 1) | ||
|
|
||
| def start_notifier(is_welcome=False): | ||
| def start_notifier(is_welcome=False, hide_grades=False): |
| return False | ||
|
|
||
| def create_instance(): | ||
| def create_instance(hide_grades=False): |
| .newline() \ | ||
| .add("You're all set up. You should see your current grades below!") \ | ||
| .add("You're all set up. You should see your current grades below!"\ | ||
| if not hide_grades else "") \ |
There was a problem hiding this comment.
continuation line under-indented for visual indent
| .add("Your UID is: {0}".format(custom_hash(user.get_username()))) \ | ||
| .newline() \ | ||
| .add("You're all set up. You should see your current grades below!") \ | ||
| .add("You're all set up. You should see your current grades below!"\ |
There was a problem hiding this comment.
the backslash is redundant between brackets
| ###********* Main Program *********### | ||
|
|
||
| def welcome_message(): | ||
| def welcome_message(hide_grades=False): |
| Changelog: The list of classes which have had grade changes | ||
| ''' | ||
| def create_text_message(change_log, is_welcome=False): | ||
| def create_text_message(change_log, is_welcome=False, hide_grades=False): |
Collaborator
Generated by 🚫 Danger |
Collaborator
|
Hey looks cool but a few changes
—hides_grades=“true” for example
|
| refresh(remaining_attempts - 1) | ||
|
|
||
| def start_notifier(is_welcome=False): | ||
| #global hide_grades |
Collaborator
|
what just happened. why are so may files changed all of a sudden |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.