First try at adding the omit grade option. - #143
Open
ymoskovits wants to merge 21 commits into
Open
Conversation
added 20 commits
January 19, 2019 19:16
pulling from remote#
…to username-hash Pulling from upstream master into username-hash.
Pulling from upstream.
Want to be able to delete local copy of username-hash branch.
Pull from upstream.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| prod = False if not args.prod else True | ||
|
|
||
| omitgrade = input( | ||
| "Enter omitgrade (True or False): ") if not args.omitgrade else args.omitgrade |
| account_pass = os.getenv('ACCOUNT_PASSWORD') | ||
|
|
||
| def run(username, password, school, phone): | ||
| def run(username, password, school, phone, omitgrade): |
| return self._number No newline at end of file | ||
| return self._number | ||
|
|
||
| def get_omitgrade(self): |
| self._school_code = school_code | ||
|
|
||
| def set_omitgrade(sef, omitgrade): | ||
| self._omitgrade = omitgrade |
| self._password = password | ||
| self._number = number | ||
| self._school_code = school_code | ||
| self._omitgrade = omitgrade; |
|
|
||
| class User(): | ||
| def __init__(self, username, password, number, school_code = None): | ||
| def __init__(self, username, password, number, school_code = None, omitgrade = False): |
There was a problem hiding this comment.
line too long (90 > 79 characters)
unexpected spaces around keyword / parameter equals
| if add_new_user_instance(username): | ||
| api = CUNYFirstAPI(username, password) | ||
| user = User(username, password, number, args.school.upper()) | ||
| user = User(username, password, number, args.school.upper(), omitgrade) |
| number = input( | ||
| "Enter phone number: ") if not args.phone else args.phone | ||
| omitgrade = input( | ||
| "Enter omitgrade (True or False): ") if not args.omitgrade else args.omitgrade |
| gpa.get_term_gpa())) .newline() .add( | ||
| "Your cumulative GPA is: {0}".format( | ||
| gpa.get_cumulative_gpa())) .newline() | ||
| if omitgrade == "False" || omitgrade != "True": |
There was a problem hiding this comment.
SyntaxError: invalid syntax
missing whitespace around operator
Collaborator
There was a problem hiding this comment.
python has the word "or" not ||
| Changelog: The list of classes which have had grade changes | ||
| ''' | ||
| def create_text_message(change_log): | ||
| def create_text_message(change_log, omitgrade): |
Collaborator
Generated by 🚫 Danger |
|
|
||
| class User(): | ||
| def __init__(self, username, password, number, school_code = None): | ||
| def __init__(self, username, password, number, school_code = None, omitgrade = "False"): |
There was a problem hiding this comment.
line too long (92 > 79 characters)
unexpected spaces around keyword / parameter equals
Huddie
reviewed
Mar 4, 2019
Huddie
left a comment
Huddie
left a comment
Collaborator
There was a problem hiding this comment.
Looks pretty good i'd say. Makes sense to me.
A few suggestions on naming. + We need omitgrades to be a boolean. String acting as a bool doesn't sound ideal.
|
|
||
| <input class="input input--full-width" type="text" name="phone" placeholder="Phone Number" required> | ||
| <br> | ||
| <input class="input" type="checkbox" name="omitgrade" value="True" >I only want a notification that my grades are available. The text can omit the actual grade I recieved.</input> |
Collaborator
There was a problem hiding this comment.
What do you think about either
- removing the last line and adding a footer that says: "The text will omit the actual grade you receive "
- Switching the wording to "The text should omit the actual grade I received"
| <br> | ||
| <input class="input" type="checkbox" name="omitgrade" value="True" >I only want a notification that my grades are available. The text can omit the actual grade I recieved.</input> | ||
| <br> | ||
| <!-- <input class="input" type="checkbox" name="lana" value="value">I also want to tweet my grades to Lana Del Rey.</input> --> |
| gpa.get_term_gpa())) .newline() .add( | ||
| "Your cumulative GPA is: {0}".format( | ||
| gpa.get_cumulative_gpa())) .newline() | ||
| if omitgrade == "False" or omitgrade != "True": |
Collaborator
There was a problem hiding this comment.
Not a fan of omitgrade being a string acting as a boolean. Let's make it a boolean outright.
| else None | ||
| if changelog is not None: | ||
| message = create_text_message(changelog) | ||
| message = create_text_message(changelog, user.get_omitgrade()) |
Collaborator
There was a problem hiding this comment.
maybe the method name could be: user.requestedGradeOmission.
Reads better I feel.
|
|
||
| class User(): | ||
| def __init__(self, username, password, number, school_code = None): | ||
| def __init__(self, username, password, number, school_code = None, omitgrade = False): |
Collaborator
There was a problem hiding this comment.
This makes sense, here omitgrade is a boolean
| def set_school_code(self, school_code): | ||
| self._school_code = school_code | ||
|
|
||
| def set_omitgrade(self, omitgrade): |
Collaborator
There was a problem hiding this comment.
method name suggestion: requestedGradeOmission
Collaborator
|
Disregard Danger/CunyBot making a fuss, I still haven't fixed it. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the code in a way that I think should add the omit grade option and its functionality. Not sure what is the best way to test it locally tho. Let me know what you guys think.