Skip to content

Remove safeguards - #140

Open
ericshermancs wants to merge 13 commits into
Grade-Notifier:masterfrom
ericshermancs:remove_safeguards
Open

Remove safeguards#140
ericshermancs wants to merge 13 commits into
Grade-Notifier:masterfrom
ericshermancs:remove_safeguards

Conversation

@ericshermancs

Copy link
Copy Markdown
Collaborator

No description provided.




def sign_in(remaining_attempts=5):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many blank lines (5)

.newline() \
.add("After that first message, the notifier will message you whenever a grade changes (or is added)!")
.newline() \
.add("After that first message, the notifier will message you whenever a grade changes (or is added)!") \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (113 > 79 characters)

@CUNY-Bot

CUNY-Bot commented Feb 1, 2019

Copy link
Copy Markdown
Collaborator
2 Errors
🚫 Please provide a summary in the Pull Request description
🚫 Oh No! You failed a unit test
Run Python3 ./src/tests/tests.py to see which test failed
../usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/email/feedparser.py:158: ResourceWarning: unclosed <ssl.SSLSocket fd=5, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=(‘10.100.8.87’, 49306), raddr=(‘128.228.24.52’, 443)>
_factory(policy=self.policy)
/usr/local/lib/python3.7/site-packages/cunyfirstapi/cunyfirstapi.py:64: ResourceWarning: unclosed <ssl.SSLSocket fd=6, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=(‘10.100.8.87’, 49313), raddr=(‘128.228.24.52’, 443)>
self._password,
F……..F.
======================================================================
FAIL: test_is_logged_in (main.TestAPIIntegration)
———————————————————————-
Traceback (most recent call last):
File “./src/tests/tests.py”, line 250, in test_is_logged_in
self.assertTrue(api2.is_logged_in(session))
AssertionError: False is not true

======================================================================
FAIL: test_print_to_screen (main.TestPrintToScreenMethod)
———————————————————————-
Traceback (most recent call last):
File “./src/tests/tests.py”, line 192, in test_print_to_screen
self.assertEqual(expected, actual)
AssertionError: ‘RENDER::This text should be displayed!\n’ != ‘RENDER:: \nThis text should be displayed!”\n[END]\n’

  • RENDER::
  • RENDER::This text should be displayed!
    ? ——–
  • This text should be displayed!”
    ? +
  • [END]

Ran 13 tests in 3.389s

FAILED (failures=2)

1 Warning
⚠️ 238 PEP 8 issues found
1 Message
📖 Thanks for remembering to declare trivial!

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants