Skip to content

chore(plugin): retire .claude-plugin/ references (GRA-1249 / GH #206)#214

Merged
Gradata merged 1 commit into
mainfrom
chore/retire-claude-plugin-references-gra-1249
May 20, 2026
Merged

chore(plugin): retire .claude-plugin/ references (GRA-1249 / GH #206)#214
Gradata merged 1 commit into
mainfrom
chore/retire-claude-plugin-references-gra-1249

Conversation

@Gradata
Copy link
Copy Markdown
Owner

@Gradata Gradata commented May 20, 2026

Summary

Final cleanup of the kill-the-plugin epic (GRA-1198 / GH #206). The .claude-plugin/ directory itself was already removed in a prior cleanup (CHANGELOG: 'Remove orphaned gradata-plugin/ subdir (#54)'). What remained were stale string references in docs and examples now that the SDK ships all subcommands directly via PRs #208/#209/#210/#211 + #213.

Changes

  • .dockerignore: removed dead .claude-plugin exclude line
  • examples/with_claude_code.py: replaced /plugin install gradata language with the canonical gradata install --agent claude-code
  • examples/README.md: fixed broken link to .claude-plugin/README.md
  • CHANGELOG.md: BREAKING entry under Unreleased

Breaking change

Anyone who installed via the /plugin marketplace add Gradata/gradata flow before 2026-05-20 must migrate:

pipx install gradata
gradata install --agent claude-code --brain ~/.gradata/brain

This is communicated via:

Verification

pip install /home/olive/work/gradata-sdk/Gradata   # in fresh venv
gradata install --agent claude-code --brain /tmp/test-brain --help
# both succeed
pytest tests/ -x -q   →  816 passed, 7 skipped, 1 pre-existing failure
# pre-existing failure: tests/test_byo_key_provider.py needs httpx (dev env, not this PR)
ruff check examples/with_claude_code.py pyproject.toml   →  All checks passed
grep -r 'claude-plugin\|gradata-plugin' src/ docs/   →  only intentional CHANGELOG hits

Epic context

GRA-1198 (kill the plugin) / GH #206. This is the last reference scrub. Companion PR for archiving the standalone Gradata/gradata-plugin repo: GRA-1250.

Authoring note

Started by a delegate_task subagent (hit max_iterations on PR-open); parent agent verified the diff was clean (extracted via git stash since 3 subagents ran in parallel on the same workdir), tested, committed, pushed, opened PR.

…-1198)

The .claude-plugin/ directory itself was already removed in a prior cleanup
(see CHANGELOG: 'Remove orphaned gradata-plugin/ subdir (#54)'). What
remained were stale string references in docs and examples now that the
SDK ships all subcommands directly (PRs #208/#209/#210/#211 + #213).

Changes:
- .dockerignore: removed dead .claude-plugin exclude line
- examples/with_claude_code.py: replaced '/plugin install gradata' language
  with the canonical 'gradata install --agent claude-code'
- examples/README.md: fix broken link to .claude-plugin/README.md
- CHANGELOG.md: BREAKING entry under Unreleased documenting the retirement

This closes out the kill-the-plugin epic (GRA-1198 / GH #206) from the
references side. Anyone who installed via /plugin marketplace before
2026-05-20 must migrate to the SDK install path.

Verified:
- pip install /home/olive/work/gradata-sdk/Gradata in a fresh venv succeeds
- gradata install --agent claude-code --brain /tmp/test-brain --help works
- pytest tests/ -x -q passes (816 tests, 7 skipped, 1 known-skip on
  test_byo_key_provider for missing httpx in dev env unrelated to this)
- ruff check clean on touched files
- grep for 'claude-plugin|gradata-plugin' on src/ + docs/ shows only the
  intentional CHANGELOG entries (current BREAKING note + historical refs)

Branch authored by delegate_task subagent (hit max_iterations on PR-open);
parent agent verified + extracted clean diff + opened PR.
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 33672645-c895-464f-b8ef-cc6d6c3dfe42

📥 Commits

Reviewing files that changed from the base of the PR and between ecc287b and 6c2d5d3.

📒 Files selected for processing (4)
  • Gradata/.dockerignore
  • Gradata/CHANGELOG.md
  • Gradata/examples/README.md
  • Gradata/examples/with_claude_code.py
💤 Files with no reviewable changes (1)
  • Gradata/.dockerignore
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: pytest (py3.11)
  • GitHub Check: pytest (py3.12)
  • GitHub Check: pytest macos-latest / py3.11
  • GitHub Check: pytest windows-latest / py3.12
  • GitHub Check: pytest windows-latest / py3.11
🔇 Additional comments (3)
Gradata/CHANGELOG.md (1)

5-11: LGTM!

Gradata/examples/with_claude_code.py (1)

1-15: LGTM!

Gradata/examples/README.md (1)

36-37: Fix broken anchor link in Gradata/examples/README.md.

The link references ../README.md#install-for-claude-code, but the top-level README only has a ## Install section (creating anchor #install), not a dedicated "Install for Claude Code" heading. Either create the missing section heading in the README or update the link to ../README.md#install.


📝 Walkthrough

Summary

  • Breaking Change: Retired plugin marketplace install path (/plugin install gradata). Users must migrate to SDK install: pipx install gradata && gradata install --agent claude-code
  • Removed .claude-plugin exclude pattern from .dockerignore
  • Updated examples/with_claude_code.py docstring to reference new gradata install --agent claude-code command instead of plugin marketplace flow
  • Updated examples/README.md to remove broken link to .claude-plugin/README.md and direct users to new install method
  • Added breaking change entry in CHANGELOG documenting retirement and migration instructions (references PR #211)
  • Final cleanup for the "kill-the-plugin" epic (GRA-1198); companion work planned for archiving standalone plugin repo (GRA-1250)
  • Verification: all tests passing (816 passed, 7 skipped), local install and gradata install --agent claude-code validated, ruff checks passed

Walkthrough

This PR consolidates the Claude Code installation experience by removing the legacy plugin marketplace install path. It updates Docker ignore rules, documents the breaking change, and redirects all example documentation to the canonical gradata install --agent claude-code command.

Changes

Plugin marketplace install retirement

Layer / File(s) Summary
Docker build context and breaking change documentation
Gradata/.dockerignore, Gradata/CHANGELOG.md
The .claude-plugin ignore pattern is removed from .dockerignore to include it in the Docker build context, and a breaking change entry is added to the changelog announcing retirement of the /plugin install gradata flow in favor of gradata install --agent claude-code.
Example documentation updates for new install command
Gradata/examples/README.md, Gradata/examples/with_claude_code.py
The examples README and module docstring are rewritten to reference gradata install --agent claude-code and point to the top-level README's install section, removing all references to the legacy .claude-plugin/README.md path and plugin marketplace install method.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Possibly related PRs

  • Gradata/gradata#211: Both PRs retire the legacy Claude Code plugin marketplace path and update docs/examples to direct users to the single canonical gradata install --agent claude-code flow.
  • Gradata/gradata#53: PR 214 removes the .claude-plugin exclusion from .dockerignore that PR 53 originally introduced as part of plugin manifest/hook wiring.
  • Gradata/gradata#54: Complements this PR's removal of .claude-plugin guidance by removing the orphaned gradata-plugin/ scaffolding and its related hook scripts/docs.

Suggested labels

docs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: retiring .claude-plugin/ references as a final cleanup for the kill-the-plugin epic.
Description check ✅ Passed The description comprehensively documents the purpose, changes, breaking change migration path, verification steps, and epic context—all directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/retire-claude-plugin-references-gra-1249

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 OpenGrep (1.21.0)

OpenGrep fatal error (exit code 2):
┌──────────────┐
│ Opengrep CLI │
└──────────────┘

�[32m✔�[39m �[1mOpengrep OSS�[0m
�[32m✔�[39m Basic security coverage for first-party code vulnerabilities.

�[1m Loading rules from local config...�[0m
[00.28][ERROR]: Error: exception Glob.Lexer.Syntax_error("malformed glob pattern: missing ']'")
Raised at Glob__Lexer.syntax_error in file "libs/glob/Lexer.mll", line 8, characters 2-26
Called from Glob__Lexer.__ocaml_lex_token_rec in file "libs/glob/Lexer.mll", line 29, characters 26-53
Cal


Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the docs label May 20, 2026
@Gradata Gradata merged commit 2914efb into main May 20, 2026
9 checks passed
@Gradata Gradata deleted the chore/retire-claude-plugin-references-gra-1249 branch May 20, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant